616628 - Unable to remove Adblock Plus from the Add-ons Manager prior to restarting Firefox

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Tobias (:Tobbi) Markus]

When trying to remove Adblock Plus from the Add-ons Manager before Firefox had been restarted, clicking the Undo link does nothing. 

In the error console, you can find the following error:
Error: uncaught exception: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.remove]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: resource://gre/modules/XPIProvider.jsm :: recursiveRemove :: line 1027"  data: no]

STR:
Go to Tools > Add-ons, install Adblock Plus.
Switch to the Extensions pane.
Next to the Adblock Plus item, click the Undo link.
=> Clicking Undo does nothing and results in the above error.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

So far we were able to reproduce it on win7 and vista. Windows XP didn't show me this failure.

Comment 2

[Dave Townsend [:mossop]]

I think this is a regression from bug 533038, I have a fix though.

Comment 3

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Need to flush the cache for the staged XPI when undoing the install. Added tests verifying that cache flushing goes on in all the cases I could think of that were necessary.

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 496193 [details] [diff] [review]
patch rev 1

Probably would be a good thing to grep for the calls LOG, WARN, ERROR to make sure they are correct.

Comment 5

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/56a617969b41

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Tobias, can you verify that this bug is now fixed for you? Thanks.

Comment 7

[Tobias (:Tobbi) Markus]

(In reply to comment #6)
> Tobias, can you verify that this bug is now fixed for you? Thanks.

Looks good in latest nightly build.

Comment 8

[LegNeato]

As per today's meeting, beta 9 will be a time-based release. Marking these all betaN+. Please move it back to beta9+ if  you believe it MUST be in the next beta (ie: trunk is in an unshippable state without this)