Closed Bug 616628 Opened 10 years ago Closed 10 years ago
Unable to remove Adblock Plus from the Add-ons Manager prior to restarting Firefox
When trying to remove Adblock Plus from the Add-ons Manager before Firefox had been restarted, clicking the Undo link does nothing. In the error console, you can find the following error: Error: uncaught exception: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.remove]" nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)" location: "JS frame :: resource://gre/modules/XPIProvider.jsm :: recursiveRemove :: line 1027" data: no] STR: Go to Tools > Add-ons, install Adblock Plus. Switch to the Extensions pane. Next to the Adblock Plus item, click the Undo link. => Clicking Undo does nothing and results in the above error.
So far we were able to reproduce it on win7 and vista. Windows XP didn't show me this failure.
blocking2.0: --- → ?
I think this is a regression from bug 533038, I have a fix though.
Assignee: nobody → dtownsend
Whiteboard: [AOMTestday] → [AOMTestday][has patch][waiting on try]
Whiteboard: [AOMTestday][has patch][waiting on try] → [AOMTestday][has patch]
Need to flush the cache for the staged XPI when undoing the install. Added tests verifying that cache flushing goes on in all the cases I could think of that were necessary.
Attachment #496193 - Flags: review?(robert.bugzilla)
Whiteboard: [AOMTestday][has patch] → [AOMTestday][has patch][needs review rs]
Comment on attachment 496193 [details] [diff] [review] patch rev 1 Probably would be a good thing to grep for the calls LOG, WARN, ERROR to make sure they are correct.
Attachment #496193 - Flags: review?(robert.bugzilla) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [AOMTestday][has patch][needs review rs] → [AOMTestday]
Target Milestone: --- → mozilla2.0b8
Tobias, can you verify that this bug is now fixed for you? Thanks.
(In reply to comment #6) > Tobias, can you verify that this bug is now fixed for you? Thanks. Looks good in latest nightly build.
Status: RESOLVED → VERIFIED
As per today's meeting, beta 9 will be a time-based release. Marking these all betaN+. Please move it back to beta9+ if you believe it MUST be in the next beta (ie: trunk is in an unshippable state without this)
No longer blocks: packedxpi
blocking2.0: beta9+ → betaN+
You need to log in before you can comment on or make changes to this bug.