616641 - Start/end caps of the download-progress binding broken on Windows/OSX with undetermined mode

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: screenshot

Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101203 Firefox/4.0b8pre

The undetermined download-progress has a graphical glitch for both start- and end-caps. While the start-cap is always green, the end-cap doesn't receive the green progress. See the screenshot.

Steps:
1. Open the link from the URL field

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Updated steps:

1. Copy the URL from the field above
2. Open the Add-ons Manager
3. Paste the URL into the location bar and hit return.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Same happens on OS X, but not with the native theme on Linux.

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch v1

This patch makes it so when the progress meter is in undetermined mode, both end caps are filled, and the colored border extends all the way around the widget (looks a lot better that way, due to both caps being filled). Also moves the buttons into the center by 2px, to make a gap between them and the end caps.

Also fixes bug 616643. Apparently, OSX has never had an undetermined mode (without manually attaching the binding, that is) - so this attaches the undetermined binding in pinstripe.

The download progress bar on Linux doesn't have end caps to round the ends, so never had this issue.

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Screenshot with patch applied, Win7

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://hg.mozilla.org/mozilla-central/rev/63fc6076169b

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101207 Firefox/4.0b8pre

The Litmus test is covered by bug 553479.