Closed Bug 616765 Opened 10 years ago Closed 10 years ago

Useless Exists check in nsUpdateDriver.cpp

Categories

(Toolkit :: Application Update, defect)

Product:
Toolkit
Component:
Application Update
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b8

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

Details

Attachments

(1 file)

patch rev1
1.22 KB, patch
mossop
: review+
mossop
: approval2.0+
Details | Diff | Splinter Review 
Found while investigating bug 616519.

The updates/0 directory will typically exist and the call to GetStatusFile is all that is needed.
Attached patch patch rev1 — — Splinter Review
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #495326 - Flags: review?(dtownsend)
Attachment #495326 - Flags: approval2.0?
(In reply to comment #0)
> Found while investigating bug 616519.
> 
> The updates/0 directory will typically exist and the call to GetStatusFile is
> all that is needed.
GetStatusFile and IsPending that is
Attachment #495326 - Flags: review?(dtownsend)
Attachment #495326 - Flags: review+
Attachment #495326 - Flags: approval2.0?
Attachment #495326 - Flags: approval2.0+
Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/12bc6188524c

This code path is tested by test_0200_app_launch_apply_update.js
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
You need to log in before you can comment on or make changes to this bug.