616785 - PageMod throws exception when XML document element inserted

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes problem

PageMod objects throw an exception when the document element for an XML document (like autocomplete.xml, which loads when the awesomebar is activated for the first time) is inserted, since they assume that documents have windows, and XML documents don't have windows:

error: An exception occurred.
Traceback (most recent call last):
  File "chrome://global/content/bindings/autocomplete.xml", line 1096, in 
    document.getAnonymousElementByAttribute(this, "anonid", "richlistbox");
  File "resource://anonid0-foo-api-utils-lib/observer-service.js", line 174, in 
    this.callback(subject, data);
  File "resource://anonid0-foo-addon-kit-lib/page-mod.js", line 185, in _onContentWindow
    if (RULES[rule].test(window.document.URL))
TypeError: window is null

Here's a simple fix that ignores documents without windows.  At some point we might consider adding support for XML documents, but this at least cleans up the console.

Comment 1

[Drew Willcoxon :adw]

Comment on attachment 495338 [details] [diff] [review]
patch v1: fixes problem

r+, let's land it, but Irakli already had a patch for this in bug 610624.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

https://github.com/mozilla/addon-sdk/commit/b3d5bc550dcb6d3a05a5d1d80a335f0bea929d40

Comment 4

[Myk Melez [:myk] [@mykmelez]]

https://github.com/mozilla/addon-sdk/commit/64ea77c833aa00b67950dba1bde1ed580a0d931c