616792 - warning: comparison between signed and unsigned from pixman-combine.c.template

Status: RESOLVED WONTFIX

(Core :: Graphics, defect)

Description

[timeless]

pixman-combine32.c
pixman-combine.c.template:
 In function ‘combine_mask_ca’:
29: warning: comparison between signed and unsigned
 In function ‘combine_mask_value_ca’:
58: warning: comparison between signed and unsigned
 In function ‘combine_mask_alpha_ca’:
79: warning: comparison between signed and unsigned
 In function ‘combine_in_reverse_ca’:
1701: warning: comparison between signed and unsigned
 In function ‘combine_out_reverse_ca’:
1766: warning: comparison between signed and unsigned
pixman-combine64.c
pixman-combine.c.template:
 In function ‘combine_mask_ca’:
29: warning: comparison between signed and unsigned
 In function ‘combine_mask_value_ca’:
58: warning: comparison between signed and unsigned
 In function ‘combine_mask_alpha_ca’:
79: warning: comparison between signed and unsigned
 In function ‘combine_in_reverse_ca’:
1701: warning: comparison between signed and unsigned
 In function ‘combine_out_reverse_ca’:
1766: warning: comparison between signed and unsigned

Comment 1

[timeless]

Attachment: patch

Comment 2

[timeless]

Attachment: linking patch

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 495347 [details] [diff] [review]
linking patch

This should be submitted upstream

Comment 4

[Chris Peterson [:cpeterson]]

Fixes for warnings in third-party code should be submitted upstream, not patched in mozilla-central.