warning: comparison between signed and unsigned from pixman-combine.c.template

RESOLVED WONTFIX

Status

()

Core
Graphics
RESOLVED WONTFIX
8 years ago
3 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

(Blocks: 1 bug)

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(1 attachment, 1 obsolete attachment)

5.93 KB, patch
jrmuizel
: review-
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
pixman-combine32.c
pixman-combine.c.template:
 In function ‘combine_mask_ca’:
29: warning: comparison between signed and unsigned
 In function ‘combine_mask_value_ca’:
58: warning: comparison between signed and unsigned
 In function ‘combine_mask_alpha_ca’:
79: warning: comparison between signed and unsigned
 In function ‘combine_in_reverse_ca’:
1701: warning: comparison between signed and unsigned
 In function ‘combine_out_reverse_ca’:
1766: warning: comparison between signed and unsigned
pixman-combine64.c
pixman-combine.c.template:
 In function ‘combine_mask_ca’:
29: warning: comparison between signed and unsigned
 In function ‘combine_mask_value_ca’:
58: warning: comparison between signed and unsigned
 In function ‘combine_mask_alpha_ca’:
79: warning: comparison between signed and unsigned
 In function ‘combine_in_reverse_ca’:
1701: warning: comparison between signed and unsigned
 In function ‘combine_out_reverse_ca’:
1766: warning: comparison between signed and unsigned
(Assignee)

Comment 1

8 years ago
Created attachment 495346 [details] [diff] [review]
patch
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #495346 - Flags: review?(jmuizelaar)
(Assignee)

Comment 2

8 years ago
Created attachment 495347 [details] [diff] [review]
linking patch
Attachment #495346 - Attachment is obsolete: true
Attachment #495347 - Flags: review?(jmuizelaar)
Attachment #495346 - Flags: review?(jmuizelaar)

Updated

7 years ago
Whiteboard: [build_warning]

Updated

7 years ago
Blocks: 187528
Comment on attachment 495347 [details] [diff] [review]
linking patch

This should be submitted upstream
Attachment #495347 - Flags: review?(jmuizelaar) → review-
Fixes for warnings in third-party code should be submitted upstream, not patched in mozilla-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.