Closed
Bug 616863
Opened 14 years ago
Closed 14 years ago
comparison between signed and unsigned integer expressions in gfxFontUtils::FindPreferredSubtable
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 605179
People
(Reporter: timeless, Assigned: timeless)
Details
Attachments
(1 file)
|
743 bytes,
patch
|
Details | Diff | Splinter Review |
gfx/thebes/gfxFontUtils.cpp: In static member function ‘static PRUint32 gfxFontUtils::FindPreferredSubtable(const PRUint8*, PRUint32, PRUint32*, PRUint32*, PRBool*)’: 535: warning: comparison between signed and unsigned integer expressions
So, i'm not really a fan of this.
The problem is that compilers are free to treat enums as signed or unsigned, this compiler treated them as signed. Here I'm casting 4 and 8 as unsigned 8 bit quantities, which is perfectly safe:
SizeOfHeader = 4,
SizeOfTable = 8,Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
Attachment #495389 -
Flags: review?(jfkthame)
You need to log in
before you can comment on or make changes to this bug.
Description
•