616920 - [Versions page] Canceling review request does not disable the add-on

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Pick an add-on with only one version
2. Load the versions page for that add-on(https://addons.allizom.org/z/en-US/developers/addon/255396/versions/)
3. Click on "Cancel Review Request" button

expected behavior:
Add-on is disabled after canceling the review request

actual behavior:
Add-on status does not change to "disabled"

Comment 1

[Andy McKay]

As per chat in IRC we thought: STATUS_UNREVIEWED made more sense. And will only show links to cancel review request when its in STATUS_LITE or STATUS_LITE_AND_NOMINATED.

Comment 2

[krupa raj[:krupa]]

We should probably change the copy in the associated confirmation box.See http://screencast.com/t/SCgQndqG . Let me know if this should be a separate bug.

Comment 3

[Andy McKay]

Or just STATUS_PENDING even...

Comment 4

[krupa raj[:krupa]]

list of add-on status is available @ http://people.mozilla.com/~chowse/drop/amo/devtools/v3/manage_addon/05_versions.png

Comment 5

[Andy McKay]

Something like? 

"Canceling your review request will prevent your addon from appearing in categories or search results."

Comment 6

[Andy McKay]

https://github.com/jbalogh/zamboni/commit/4d61a3ec4662b1b7027e45766125068b15983d24

Comment 7

[krupa raj[:krupa]]

Canceling review request for an add-on will now change that add-on's status to "incomplete"

verified @ https://addons.allizom.org/z/en-US/developers/addon/255402/versions/