Closed Bug 617004 Opened 14 years ago Closed 13 years ago

optimize GCMember dtor

Categories

(Tamarin Graveyard :: Garbage Collection (mmGC), defect, P2)

Product:
Tamarin Graveyard
Component:
Garbage Collection (mmGC)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Q3 11 - Serrano

People

(Reporter: treilly, Assigned: treilly)

References

Details

Attachments

(1 file)

Specialize dtor by T
1.65 KB, patch
lhansen
: review+
Details | Diff | Splinter Review 
In WriteBarrier<T> the dtor just does t=0.  But GCMember is more elaborate calling T::WriteBarrier.   We should call an inlined T::WriteBarrier_dtor which just writes zero for GCObject/GCFinalizedObject and just does RC handling for RCObject.
Assignee: nobody → treilly
Status: NEW → ASSIGNED
Blocks: 617005
Flags: flashplayer-bug-
Priority: P2 → P3
Priority: P3 → P4
Priority: P4 → P2

        Attachment #526079 -
        Flags: review?(lhansen)

    
  

        Attachment #526079 -
        Flags: review?(lhansen) → review+

    
    

    
  
changeset: 6181:e10df5b47062
user:      Tommy Reilly <treilly@adobe.com>
summary:   Bug 617004 - optimize GCMember dtor (r=lhansen)

http://hg.mozilla.org/tamarin-redux/rev/e10df5b47062

    
  
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: