Closed
Bug 617030
Opened 15 years ago
Closed 15 years ago
JSONP code does not conform to the docs and throws an error with code 32000
Categories
(Bugzilla :: WebService, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.0
People
(Reporter: mkanat, Assigned: mkanat)
Details
Attachments
(1 file)
|
1002 bytes,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
There's a slight error in the JSONP code in Bugzilla::WebService::Server::JSONRPC--it only accepts 0 and 1 as numbers, instead of 0 through 9. Also, it throws json_rpc_invalid_callback with an error code of 32000, when really that should have its own error code.
Flags: blocking4.0+
|
Assignee | |
Updated•15 years ago
|
Summary: JSONP code does not conform to the docs and throws an error with code 3200 → JSONP code does not conform to the docs and throws an error with code 32000
|
|
Assignee | |
Comment 1•15 years ago
|
||
This is a very simple, pretty obviously-correct patch.
|
|
||
Comment 2•15 years ago
|
||
Comment on attachment 495527 [details] [diff] [review]
v2
r=LpSolit
Attachment #495527 -
Flags: review?(LpSolit) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
Thanks for the review, LpSolit! :-)
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/WebService/Constants.pm
modified Bugzilla/WebService/Server/JSONRPC.pm
Committed revision 7614.
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/4.0/
modified Bugzilla/WebService/Constants.pm
modified Bugzilla/WebService/Server/JSONRPC.pm
Committed revision 7491.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: approval4.0+
Flags: approval+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•