617068 - Match the specification for input.{select,selectionStart,selectionEnd,setSelectionRange}

Status: NEW

(Core :: DOM: Selection, task)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

The spec says, in a well hidden place:

> When these methods and attributes are used with input elements while they
> don't apply, they must raise an INVALID_STATE_ERR exception. Otherwise, they
> must act as described below.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Match the specification for input.{select,selectionStart,selectionEnd,setSelectionRange}

Comment 2

[Mounir Lamouri (:mounir)]

Do we really want to do that? That might break scripts, isn't it?
I think we should ask for a change in the specs like we did for |.files|.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

What do other browsers do? I can't say I care strongly, though in general not throwing is nice.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

I should note that we already throw due to the lack of an nsITextControlFrame; the main behavioral change is in select(). (Actually, we also throw in the case of a display:none input.)

Comment 5

[(no longer active)]

Comment on attachment 495574 [details] [diff] [review]
Match the specification for input.{select,selectionStart,selectionEnd,setSelectionRange}

This patch does the wrong thing when getting the selection range at least.  We can't just return 0 when we don't have a frame.  The patch here should be rewritten on top of the patch in bug 692520.

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Anyway, I think I already removed this from my queue due to lack of reviewer responsiveness.

Comment 7

[(no longer active)]

(In reply to Ms2ger from comment #6)
> Anyway, I think I already removed this from my queue due to lack of reviewer
> responsiveness.

Next time try bz?  He r+'ed my patch before I submitted it to the try server.  ;-)

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Sadly enough, it does seem hard to get a review if you're not asking bz or smaug...

Comment 9

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.