617069 - Contacts autocomplete is broken for id and className matches

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

We check for type="xxx" first cause we <3 HTML5, but we also fallback to some regex on the id="xxx" and class="xxx". The fallback is broken.

It's a regression from bug 596959.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: tests

I've wrote a few tests to prevent regressing this again. 
The "rel" test is still failing though, maybe this is because "rel" is not part of the nsIDOMHTMLInputElement but of nsIDOMHTML[Anchor/Link]Element which make me wonder why it lives into the autocomplete component in this case?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Yes, I'll remove "rel" from the specialProps. We don't add it to the fake object in _getJSON (in forms.js) so it doesn't work. I don't think we should keep using it, so I can remove it on checkin.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 495562 [details] [diff] [review]
patch

r+ with rel removal

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/4bf4c921d01a
http://hg.mozilla.org/mobile-browser/rev/b5295c53c945

Comment 5

[Martijn Wargers (dead)]

I can see the tests residing in:
http://mxr.mozilla.org/mobile-browser/source/chrome/tests/browser_contacts.js#78
So marking in-testsuite+.

Comment 6

[Martijn Wargers (dead)]

Attachment: testcase

I'm trying to verify this bug.
My results on the N900 are that I'm getting the telephone autocomplete entries for the type=tel, id=tel and the name=tel inputs. Not for the class=tel or the rel=tel inputs.
Is that what should be expected?

Btw, I'm not getting any telephone autocomplete entries at all for the Droid device, even though I have at least 1 phone number in there.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #6)
> Created attachment 501470 [details]
> testcase
> 
> I'm trying to verify this bug.
> My results on the N900 are that I'm getting the telephone autocomplete entries
> for the type=tel, id=tel and the name=tel inputs. Not for the class=tel or the
> rel=tel inputs.
> Is that what should be expected?

yes

Comment 8

[Martijn Wargers (dead)]

Ok, thanks for explaining.
Marking verified fixed then.

Comment 9

[Dão Gottwald [:dao]]

bugspam