Closed Bug 617069 Opened 9 years ago Closed 9 years ago

Contacts autocomplete is broken for id and className matches

Categories

(Firefox for Android Graveyard :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(3 files)

Attached patch patchSplinter Review
We check for type="xxx" first cause we <3 HTML5, but we also fallback to some regex on the id="xxx" and class="xxx". The fallback is broken.

It's a regression from bug 596959.
Attachment #495562 - Flags: review?(21)
Attached patch testsSplinter Review
I've wrote a few tests to prevent regressing this again. 
The "rel" test is still failing though, maybe this is because "rel" is not part of the nsIDOMHTMLInputElement but of nsIDOMHTML[Anchor/Link]Element which make me wonder why it lives into the autocomplete component in this case?
Yes, I'll remove "rel" from the specialProps. We don't add it to the fake object in _getJSON (in forms.js) so it doesn't work. I don't think we should keep using it, so I can remove it on checkin.
Whiteboard: [fennec-checkin-postb3]
pushed:
http://hg.mozilla.org/mobile-browser/rev/4bf4c921d01a
http://hg.mozilla.org/mobile-browser/rev/b5295c53c945
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fennec-checkin-postb3]
I can see the tests residing in:
http://mxr.mozilla.org/mobile-browser/source/chrome/tests/browser_contacts.js#78
So marking in-testsuite+.
Flags: in-testsuite+
Attached file testcase
I'm trying to verify this bug.
My results on the N900 are that I'm getting the telephone autocomplete entries for the type=tel, id=tel and the name=tel inputs. Not for the class=tel or the rel=tel inputs.
Is that what should be expected?

Btw, I'm not getting any telephone autocomplete entries at all for the Droid device, even though I have at least 1 phone number in there.
(In reply to comment #6)
> Created attachment 501470 [details]
> testcase
> 
> I'm trying to verify this bug.
> My results on the N900 are that I'm getting the telephone autocomplete entries
> for the type=tel, id=tel and the name=tel inputs. Not for the class=tel or the
> rel=tel inputs.
> Is that what should be expected?

yes
Ok, thanks for explaining.
Marking verified fixed then.
Status: RESOLVED → VERIFIED
bugspam
Assignee: nobody → mark.finkle
You need to log in before you can comment on or make changes to this bug.