Closed
Bug 617071
Opened 9 years ago
Closed 9 years ago
SQLiteMutex.h breaks debug builds with system sqlite
Categories
(Toolkit :: Storage, defect)
Toolkit
Storage
Not set
Tracking
()
RESOLVED
FIXED
People
(Reporter: mano, Assigned: mano)
Details
Attachments
(1 file, 1 obsolete file)
|
578 bytes,
patch
|
sdwilsh
:
review+
sdwilsh
:
approval2.0+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #495565 -
Flags: review?(sdwilsh)
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → mano
|
||
Comment 1•9 years ago
|
||
I think it would be better to modify this ifdef:https://mxr.mozilla.org/mozilla-central/source/storage/src/SQLiteMutex.h#86 To also handle the case where we use system sqlite.
|
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #495565 -
Attachment is obsolete: true
Attachment #495565 -
Flags: review?(sdwilsh)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #495576 -
Flags: review?(sdwilsh)
|
|
||
Comment 3•9 years ago
|
||
Comment on attachment 495576 [details] [diff] [review] patch r=sdwilsh
Attachment #495576 -
Flags: review?(sdwilsh)
Attachment #495576 -
Flags: review+
Attachment #495576 -
Flags: approval2.0+
|
|
Assignee | |
Comment 4•9 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/efc2bc1058df
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•