Make sure we're not using cltbld user anywhere in buildbot/build/release harnesses

RESOLVED FIXED

Status

Mozilla Messaging
Release Engineering
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: standard8, Assigned: jhopkins)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
We shouldn't be using cltbld anywhere these days, we should be using tbirdbld.

At the moment it looks like the release code may be hitting cltbld in some weird fashion:

http://mxr.mozilla.org/build/search?string=cltbld&find=%2Fthunderbird%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=build

cvs -d :ext:cltbld@cvs.mozilla.org:/cvsroot co -dpatcher-configs mozilla/tools/patcher-configs

Bug 517227 says tbirdbld has access to mozilla/tools, so we should try and verify that and then switch the buildbot release code over.
(Assignee)

Comment 1

7 years ago
Created attachment 505330 [details] [diff] [review]
Use tbirdbld to access CVS

I believe these are the only changes needed.
Attachment #505330 - Flags: review?(gozer)
Comment on attachment 505330 [details] [diff] [review]
Use tbirdbld to access CVS

looks good, needs testing.

On the linux slaves (at least), check in ~cltbld/.ssh/config:

[...]
Host cvs.mozilla.org
        IdentityFile ~/.ssh/cltbld_dsa

Not sure if that's still needed, but that's something else.

Also, the cltbld ssh key itself should be nuked from the slaves, that would let us catch any other omissions too.
Attachment #505330 - Flags: review?(gozer) → review+
Depends on: 609337
(Assignee)

Updated

7 years ago
Assignee: nobody → jhopkins
(Assignee)

Comment 3

7 years ago
~/.ssh/cltbld_dsa has been removed from all the build slaves, and ~/.ssh/config files updated to use tbirdbld instead.
(Assignee)

Comment 4

7 years ago
Landed patch in https://hg.mozilla.org/build/buildbot-configs/rev/1602e4093ed5

Tested tbirdbld@cvs.mozilla.org access with tbirdbld SSH key, works fine.  Going to mark as resolved as I don't expect any issues.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Thanks guys!
(Assignee)

Comment 6

7 years ago
Unfortunately, CVS write access isn't quite as simple as I thought.  There's the SSH key, plus another auth mechanism which is preventing write access at the moment.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

7 years ago
Depends on: 664013
No longer depends on: 609337
(Assignee)

Comment 7

7 years ago
Thanks to our server-ops friends, the fix was turned around quickly!
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.