617150 - Sync UI: Quota dialog should display "0 bytes" when no value present

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[:Atoll]

Currently, the quota dialog displays a blank field when the collection_usage for a given collection (eg. Tabs or Passwords) is either "0", or not present in the collection_usage response at all.

Is this the desired behavior?  It looks broken when I don't know any better.

Steps to reproduce:

Create a new profile.  Bookmark a page.  Set up first time sync.  Wait for first sync to complete.  View quotas.

Expected result:

Passwords should show 0.0 KB.

Actual result:

Passwords is blank.

Comment 1

[Philipp von Weitershausen [:philikon]]

(In reply to comment #0)
> Currently, the quota dialog displays a blank field when the collection_usage
> for a given collection (eg. Tabs or Passwords) is either "0", or not present in
> the collection_usage response at all.
> 
> Is this the desired behavior?  It looks broken when I don't know any better.

Yeah I agree.

> Passwords should show 0.0 KB.

I'm not sure why it should be "0.0 KB" and not "0 KB" or "0 bytes". I'm using the download manager's formatting code and that shows a zero value as "0 bytes". It doesn't really matter anyway since the objective is to show *something* when the value isn't present or zero.

Comment 2

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Comment 3

[Philipp von Weitershausen [:philikon]]

Comment on attachment 498542 [details] [diff] [review]
v1

I'm not entirely happy with this patch: if we fail to get the info (e.g. in offline mode), we now display 0 bytes as well. That doesn't seem right. Will adjust that.

Comment 4

[Philipp von Weitershausen [:philikon]]

Attachment: v1.1

Don't set the labels to "0 bytes" if we couldn't get the quota info.

Comment 5

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/mozilla-central/rev/c833cf2e69ef

Comment 6

[Tobias (:Tobbi) Markus]

Verified against trunk from 2011-01-14.