617175 - deleteTabValue doesn't use early access

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect)

Description

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

We've allowed values to be set and retrieved via "early access" but not removed. This is (partly) causing the race condition in bug 617117 that's causing a random orange.

Comment 1

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1

This fixed bug 617117 for me - I reproduced that by adding a bunch of tabs before trying to deleteTabValue.

This also comes with tests! Just added to the tests for bug 590268 since they had the infrastructure to test this. I had to wrap in a try-catch otherwise it would just die in the loop there and the tests as a whole would still pass. Added an extra check that we at least do one proper testing of the get/set/delete with early access.

Comment 2

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Bug 590268 was blocking+ and since this is mostly an extension of that bug, blocking? on this one too.

Comment 3

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.2 (for check-in)

s/is/ok/ to fix that failure from try (should never have been an is check!)

Comment 4

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Pushed http://hg.mozilla.org/mozilla-central/rev/8531d0ed4546

Comment 5

[u279076]

Is there a way I can verify this bug?

Comment 6

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

(In reply to comment #5)
> Is there a way I can verify this bug?

test passes