617177 - Filter type (happy/sad) doesn't persist when paginating through Themes

Status: RESOLVED WONTFIX

(Input :: General, defect, P2)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

This is in prod, as well, but it'd be nice if we could get a fix in time for the freeze/shortly after.

STR:

1. Load http://input.stage.mozilla.com/en-US/themes/?s=sad
2. Click on "Older Messages"

Actual Results:

http://input.stage.mozilla.com/en-US/themes/?page=2 loads (without the s=sad param/value)

Expected Results:

http://input.stage.mozilla.com/en-US/themes/?s=sad&page=2

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

This is the same for any filter in Themes. The filters are not being persisted when changing the page of results.

Interestingly, the page number is persisted when applying a filter, which probably shouldn't be the case. I've raised this as bug 617508.

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Added testcase in litmus 15018

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Added automated test with assertions commented out until this issue has been fixed. See https://github.com/mozilla/input-tests/pull/7

Comment 4

[Fred Wenzel [:wenzel]]

The themes page uses the pager helper in input.helpers. That helper does not preserve URL parameters. We could make it just spit out the existing GET parameters along with the new page -- keep in mind that that can be arbitrary user data, but checking against a parameter whitelist would make the solution quite a bit more complicated.

Comment 5

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Moving theme related stuff to FUTURE, the expectation is that michaelk will work on his end as time permits, and that it'll be a priority on my plate - but I don't want to move it into a milestone, because it's being blocked by michaelk who is busy with BZETL.  Once his portion is complete, I'll move the remaining bugs into a milestone.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

New Input doesn't have themes, so this isn't relevant anymore.