617178 - [prod] [traceback] TypeError: not all arguments converted during string formatting

Status: VERIFIED FIXED

(Input :: General, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

http://input.stage.mozilla.com/ru/themes/?a=firefox&s=happy&page=2 is giving me:

Traceback (most recent call last):

  File "/data/www/input.stage.mozilla.com/reporter/vendor/packages/Django/django/core/handlers/base.py", line 100, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/input.stage.mozilla.com/reporter/vendor/packages/Django/django/utils/decorators.py", line 76, in _wrapped_view
    response = view_func(request, *args, **kwargs)

  File "/data/www/input.stage.mozilla.com/reporter/apps/input/decorators.py", line 33, in cached_view
    return f(request, *args, **kwargs)

  File "/data/www/input.stage.mozilla.com/reporter/apps/themes/views.py", line 114, in index
    return jingo.render(request, 'themes/index.html', args)

  File "/data/www/input.stage.mozilla.com/reporter/vendor/src/jingo/jingo/__init__.py", line 63, in render
    rendered = render_to_string(request, template, context)

  File "/data/www/input.stage.mozilla.com/reporter/vendor/src/jingo/jingo/__init__.py", line 84, in render_to_string
    return template.render(**get_context())

  File "/data/www/input.stage.mozilla.com/reporter/vendor/packages/jinja2/jinja2/environment.py", line 891, in render
    return self.environment.handle_exception(exc_info, True)

  File "/data/www/input.stage.mozilla.com/reporter/apps/themes/templates/themes/index.html", line 1, in top-level template code
    {% extends "base.html" %}

  File "/data/www/input.stage.mozilla.com/reporter/templates/base.html", line 45, in top-level template code
    {% block content %}{% endblock %}

  File "/data/www/input.stage.mozilla.com/reporter/apps/themes/templates/themes/index.html", line 33, in block "content"
    {{ theme_list(themes) }}

  File "/data/www/input.stage.mozilla.com/reporter/vendor/src/jingo/jingo/__init__.py", line 123, in wrapper
    t = env.get_template(template).render(context)

  File "/data/www/input.stage.mozilla.com/reporter/vendor/packages/jinja2/jinja2/environment.py", line 891, in render
    return self.environment.handle_exception(exc_info, True)

  File "/data/www/input.stage.mozilla.com/reporter/apps/themes/templates/themes/theme_list.html", line 13, in top-level template code
    {% trans count=(theme.num_opinions-1)|numberfmt %}

  File "/data/www/input.stage.mozilla.com/reporter/vendor/src/tower/tower/__init__.py", line 38, in ungettext
    ret = django_nugettext(singular, plural, number)

  File "/data/www/input.stage.mozilla.com/reporter/vendor/packages/Django/django/utils/translation/__init__.py", line 58, in ungettext
    return real_ungettext(singular, plural, number)

  File "/data/www/input.stage.mozilla.com/reporter/vendor/packages/Django/django/utils/functional.py", line 55, in _curried
    return _curried_func(*(args+moreargs), **dict(kwargs, **morekwargs))

  File "/data/www/input.stage.mozilla.com/reporter/vendor/packages/Django/django/utils/translation/__init__.py", line 36, in delayed_loader
    return getattr(trans, real_name)(*args, **kwargs)

  File "/data/www/input.stage.mozilla.com/reporter/vendor/packages/Django/django/utils/translation/trans_real.py", line 310, in ungettext
    return do_ntranslate(singular, plural, number, 'ungettext')

  File "/data/www/input.stage.mozilla.com/reporter/vendor/packages/Django/django/utils/translation/trans_real.py", line 292, in do_ntranslate
    return getattr(t, translation_function)(singular, plural, number)

  File "/usr/lib/python2.6/gettext.py", line 411, in ungettext
    tmsg = self._catalog[(msgid1, self.plural(n))]

  File "<string>", line 1, in <lambda>

TypeError: not all arguments converted during string formatting

Comment 1

[Fred Wenzel [:wenzel]]

Michael: When you a {% trans %} block with {% pluralize %}, you need to provide the argument num=123 so it knows what plural form to use.

https://github.com/fwenzel/reporter/commit/8c33021

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on http://input.stage.mozilla.com/ru/themes/?a=firefox&s=happy&page=2.

Comment 3

[Michael Kurze [:michaelk]]

Ah, thanks for that info! I need to make a habit of testing localized versions as well.

Comment 4

[Matt Brandt [:mbrandt]]

http://input.mozilla.org/ru/sites and http://input.allizom.org/ru/sites is giving me:



Traceback (most recent call last):

 File "/data/www/input.stage.mozilla.com/reporter/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/www/input.stage.mozilla.com/reporter/vendor/src/django/django/utils/decorators.py", line 93, in _wrapped_view
   response = view_func(request, *args, **kwargs)

 File "/data/www/input.stage.mozilla.com/reporter/apps/input/decorators.py", line 43, in cached_view
   return f(request, *args, **kwargs)

 File "/data/www/input.stage.mozilla.com/reporter/apps/website_issues/views.py", line 103, in website_issues
   return jingo.render(request, 'website_issues/sites.html', data)

 File "/data/www/input.stage.mozilla.com/reporter/vendor/src/jingo/jingo/__init__.py", line 75, in render
   rendered = render_to_string(request, template, context)

 File "/data/www/input.stage.mozilla.com/reporter/vendor/src/jingo/jingo/__init__.py", line 93, in render_to_string
   return template.render(get_context())

 File "/data/www/input.stage.mozilla.com/reporter/vendor/src/jingo/jingo/__init__.py", line 189, in render
   return super(Template, self).render(context_dict)

 File "/data/www/input.stage.mozilla.com/reporter/vendor/packages/jinja2/jinja2/environment.py", line 891, in render
   return self.environment.handle_exception(exc_info, True)

 File "/data/www/input.stage.mozilla.com/reporter/apps/website_issues/templates/website_issues/sites.html", line 13, in top-level template code
   href="{{ base_url|urlparams(**{name: value, 'page': None}) }}">{{ label }}</a>

 File "/data/www/input.stage.mozilla.com/reporter/templates/base.html", line 45, in top-level template code
   {% block content %}{% endblock %}

 File "/data/www/input.stage.mozilla.com/reporter/apps/website_issues/templates/website_issues/sites.html", line 61, in block "content"
   {% include "website_issues/includes/sites_list.html" %}

 File "/data/www/input.stage.mozilla.com/reporter/apps/website_issues/templates/website_issues/includes/sites_list.html", line 46, in top-level template code
   {% trans count=site.size|numberfmt %}

 File "/data/www/input.stage.mozilla.com/reporter/vendor/src/tower/tower/__init__.py", line 38, in ungettext
   ret = django_nugettext(singular, plural, number)

 File "/data/www/input.stage.mozilla.com/reporter/vendor/src/django/django/utils/translation/__init__.py", line 84, in ungettext
   return _trans.ungettext(singular, plural, number)

 File "/data/www/input.stage.mozilla.com/reporter/vendor/src/django/django/utils/translation/trans_real.py", line 328, in ungettext
   return do_ntranslate(singular, plural, number, 'ungettext')

 File "/data/www/input.stage.mozilla.com/reporter/vendor/src/django/django/utils/translation/trans_real.py", line 310, in do_ntranslate
   return getattr(t, translation_function)(singular, plural, number)

 File "/usr/lib/python2.6/gettext.py", line 411, in ungettext
   tmsg = self._catalog[(msgid1, self.plural(n))]

 File "<string>", line 1, in <lambda>

TypeError: not all arguments converted during string formatting

Comment 5

[Matt Brandt [:mbrandt]]

(In reply to Matt Brandt [:mbrandt] from comment #4)
> http://input.mozilla.org/ru/sites and http://input.allizom.org/ru/sites is
> giving me:

A bit more info:
 'HTTP_HOST': 'input.allizom.org',
 'HTTP_USER_AGENT': 'Mozilla/5.0 (compatible; YandexBot/3.0; +http://yandex.com/bots)',

Comment 6

[[github robot]]

Commit pushed to https://github.com/mozilla/input.mozilla.org

https://github.com/mozilla/input.mozilla.org/commit/fd07672375e5febdb371e3b57cbc86b0469f543c
Using trans correctly, fix bug 617178

Comment 7

[[github robot]]

Commit pushed to https://github.com/mozilla/input.mozilla.org

https://github.com/mozilla/input.mozilla.org/commit/fd07672375e5febdb371e3b57cbc86b0469f543c
Using trans correctly, fix bug 617178

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED:

[15:55:27.669] GET http://input.mozilla.org/ru/sites [HTTP/1.1 200 OK 107ms]

[15:57:16.911] GET http://input.allizom.org/ru/sites [HTTP/1.1 200 OK 278ms]