617284 - Composition window busted due to JavaScript error: chrome://editor/content/editorUtilities.js unterminated regular expression literal

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Mark Banner (:standard8)]

The composition window is broken:

JavaScript error: chrome://editor/content/editorUtilities.js, line 638: unterminated regular expression literal

This is tracked down to here:

http://hg.mozilla.org/comm-central/annotate/42371756f234/editor/ui/composer/content/editorUtilities.js#l638

  return selectedText && /^http:\/\/|^https:\/\/|^file:\/\/|\
    ^ftp:\/\/|^about:|^mailto:|^news:|^snews:|^telnet:|^ldap:|\
    ^ldaps:|^gopher:|^finger:|^javascript:/i.test(selectedText);

I think this is due to the latest tracemonkey merge:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=73ba6e1c2b05&tochange=37b29506a7d4

Comment 1

[Mark Banner (:standard8)]

I've just landed a temporary bustage fix that should work around the issue:

http://hg.mozilla.org/comm-central/rev/1dc9fb072bf4

This makes the regexp all one line, and should get the tree green again. I'll then take a look at which bug actually busted this (it doesn't seem intentional from the bug descriptions).

Comment 2

[Mark Banner (:standard8)]

Oh, SeaMonkey's nightlies may be affected as they will have already built, Thunderbird's nightlies haven't started yet so they should be fine.

Comment 3

[Mark Banner (:standard8)]

I got the regression range wrong, its actually the previous merge:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e24641018d51&tochange=2f96714fd6d2

I'm bisecting at the moment.

Comment 4

[Mark Banner (:standard8)]

Ok, the regression bug was bug 615070, however it turns out that it was a correctness bug for javascript ES5. 

So the temporary fix is actually a permanent fix, I'm going to close this, but Neil can feel free to re-open if he wants this fixed in a better way.