617350 - hgtool.py shouldn't update shared checkout

Status: RESOLVED FIXED

(Release Engineering :: General, enhancement, P5)

Description

[Chris AtLee [:catlee]]

From a recent valgrind run:

command: START
command: arg0: hg
command: args: ['update', '-C']
command: cwd: /builds/hg-shared/mozilla-central
command: output:
48901 files updated, 0 files merged, 0 files removed, 0 files unresolved
command: END

command: START
command: arg0: hg
command: args: ['parent', '--template', '{node|short}']
command: cwd: /builds/hg-shared/mozilla-central
command: output:
a2743e6bc5e8
command: END

There's no need to be updating the working copy in the shared checkout directory.

Comment 1

[Syed Albiz [:salbiz]]

Attachment: stop updating shared checkout

Passes unit tests, shouldn't affect any existing callers, since the default is to update the destination, so will only pull without updating if explicitly called with update_dest=False.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 496243 [details] [diff] [review]
stop updating shared checkout

Seems reasonable!

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 496243 [details] [diff] [review]
stop updating shared checkout

changeset:   1912:d2d38517e14a

Comment 4

[[e-mail] (:bhearsum)]

I think this bug is done now.

Comment 5

[Chris AtLee [:catlee]]

I think this is still happening, for the initial clone at least:

command: START
command: arg0: hg
command: args: ['clone', '-U', '-r', 'c7e8cab4d34f', 'http://hg.mozilla.org/try', '/builds/hg-shared/try']
command: cwd: /builds/slave/try-lnx
command: output:
requesting all changes
adding changesets
adding manifests
adding file changes
added 61165 changesets with 286648 changes to 70908 files
command: END

command: START
command: arg0: hg
command: args: ['update', '-C', '-r', 'c7e8cab4d34f']
command: cwd: /builds/hg-shared/try
command: output:
49607 files updated, 0 files merged, 0 files removed, 0 files unresolved
command: END

Comment 6

[Chris AtLee [:catlee]]

This got fixed at some point