If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

hgtool.py shouldn't update shared checkout

RESOLVED FIXED

Status

Release Engineering
General
P5
enhancement
RESOLVED FIXED
7 years ago
4 years ago

People

(Reporter: catlee, Assigned: catlee)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [automation])

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
From a recent valgrind run:

command: START
command: arg0: hg
command: args: ['update', '-C']
command: cwd: /builds/hg-shared/mozilla-central
command: output:
48901 files updated, 0 files merged, 0 files removed, 0 files unresolved
command: END

command: START
command: arg0: hg
command: args: ['parent', '--template', '{node|short}']
command: cwd: /builds/hg-shared/mozilla-central
command: output:
a2743e6bc5e8
command: END

There's no need to be updating the working copy in the shared checkout directory.
Severity: normal → enhancement
Priority: -- → P5
Whiteboard: [automation]

Comment 1

7 years ago
Created attachment 496243 [details] [diff] [review]
stop updating shared checkout

Passes unit tests, shouldn't affect any existing callers, since the default is to update the destination, so will only pull without updating if explicitly called with update_dest=False.
Assignee: nobody → salbiz
Status: NEW → ASSIGNED
Attachment #496243 - Flags: review?(catlee)
Attachment #496243 - Flags: review?(bhearsum)
(Assignee)

Updated

7 years ago
Attachment #496243 - Flags: review?(catlee) → review+
Comment on attachment 496243 [details] [diff] [review]
stop updating shared checkout

Seems reasonable!
Attachment #496243 - Flags: review?(bhearsum) → review+
Comment on attachment 496243 [details] [diff] [review]
stop updating shared checkout

changeset:   1912:d2d38517e14a
Attachment #496243 - Flags: checked-in+
I think this bug is done now.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

7 years ago
I think this is still happening, for the initial clone at least:

command: START
command: arg0: hg
command: args: ['clone', '-U', '-r', 'c7e8cab4d34f', 'http://hg.mozilla.org/try', '/builds/hg-shared/try']
command: cwd: /builds/slave/try-lnx
command: output:
requesting all changes
adding changesets
adding manifests
adding file changes
added 61165 changesets with 286648 changes to 70908 files
command: END

command: START
command: arg0: hg
command: args: ['update', '-C', '-r', 'c7e8cab4d34f']
command: cwd: /builds/hg-shared/try
command: output:
49607 files updated, 0 files merged, 0 files removed, 0 files unresolved
command: END
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

7 years ago
Assignee: s.s.albiz → catlee
(Assignee)

Comment 6

7 years ago
This got fixed at some point
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.