Closed
Bug 617351
Opened 14 years ago
Closed 14 years ago
More tests for engine disabling
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
People
(Reporter: rnewman, Assigned: rnewman)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
7.25 KB,
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
Firstly, this deserves CrossWeave tests. Secondly, we need to automate the two-client engine disable situation. Tips from Philipp re faking client count: 09:18:01 <@philiKON> rnewman: i guess the trick is to just override Clients.stats.numclients 09:18:28 <@philiKON> rnewman: which is based on Clients._store._remoteClients 09:18:59 <@rnewman> I attempted setting Service.numClients, but of course the sync itself corrects that number 09:19:06 <@philiKON> yeah 09:19:07 <@rnewman> stats seems like a better approach 09:19:16 <@rnewman> I'll attack that after the meeting 09:19:36 <@philiKON> rec = new ClientRec(); ...; Clients._store.update(rec);
Assignee | ||
Comment 1•14 years ago
|
||
I fixed the test suite somewhat, and added a test that simulates disabling from another client. All tests pass, along with CrossWeave.
Attachment #496001 -
Flags: review?(mconnor)
Updated•14 years ago
|
Attachment #496001 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 2•14 years ago
|
||
Pushed: http://hg.mozilla.org/services/fx-sync/rev/dc4eb78251af
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 3•14 years ago
|
||
(In reply to comment #0) > Firstly, this deserves CrossWeave tests. Filed bug 617526.
Updated•13 years ago
|
Whiteboard: [qa-]
Updated•6 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•