Closed Bug 617389 Opened 10 years ago Closed 1 year ago

XUL applications stay in offline mode when built with --disable-necko-wifi

Categories

(Core :: Networking, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: laga, Unassigned)

Details

(Keywords: regression)

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101027 Firefox/3.6
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101027 Firefox/3.6

When building Firefox with --disable-necko-wifi and using the resulting firefox executable to run XUL applications (firefox -app application.ini), Firefox will remain in offline mode. Interestingly enough, in regular firefox mode, browsing the web will work flawlessly.

Reproducible: Always

Steps to Reproduce:
1.Build current firefox
2.Run XULRunner application which tries to access the web (eg <browser src="http://www.heise.de>")

Actual Results:  
I see a window telling me that Firefox is currently in offline mode.

Expected Results:  
I expect that heise.de loads in my browser element.

Ehsan was kind of enough to provide a workaround:

Components.classes["@mozilla.org/network/io-service;1"].getService(Components.interfaces.nsIIOService).offline = false

This will disable offline mode (or rather, switch to online mode). Bug #616520 might be related.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee: nobody → ehsan
ehsan pointed to bug 614958, which might have regressed this.
Keywords: regression
This is basically another reincarnation of bug 616520.  I'll attach a patch to that bug which will fix this one as well.
Depends on: 616520
Whiteboard: [will be fixed by bug 616520]
The default status is one thing. (thanks for fixing that)
But I don't think we should let automatics entirely take over, like it does now. It should be opt-in, not opt-out.
(See bug 565564 for the conceptual problems.)
In fact, not even *opt-out* worked anymore: laga told me that he set, in defaults/preferences/prefs.js:
pref("network.manage-offline-status", false);
pref("toolkit.networkmanager.disable", true);
pref("browser.offline", false);
pref("browser.offline-apps.notify", false);
That should really disable the detection, but it didn't.

So, from my view, we have 3 bugs here:
1) offline when network manager is not available, fixed in bug 616520.
2) default to use network manager, instead default to not using it
   (see last 2 comments), esp. for XULrunner.
3) manual disabling prefs don't work.
> bug 616520.  I'll attach a patch to that bug which will fix this one as well.

Commited. Thanks, ehsan!

> 1) offline when network manager is not available, fixed in bug 616520.

Fixed.

> 2) default to use network manager, instead default to not using it
>    (see last 2 comments), esp. for XULrunner.
> 3) manual disabling prefs don't work.

Still open
No longer depends on: 616520
Whiteboard: [will be fixed by bug 616520]
Are we morphing this bug to cover 2, and 3 as well?  In that case, back to @nobody!
Assignee: ehsan → nobody
Component: Shell Integration → Networking
Product: Firefox → Core

I am 90% sure this doesn't happen anymore.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.