617426 - add version 6 of V8 testsuite to benchmark repo

Status: VERIFIED FIXED

(Tamarin Graveyard :: Build Config, defect)

Description

[Trevor Baker]

Need js, untyped, typed and optimized versions of version6 of V8 checked into the benchmark repo.

new home should be tamarin/v8.6

Might be expedient to start by diffing v5 and v6 then apply same changes to our ported v5 tests, rather than starting from scratch.

http://v8.googlecode.com/svn/data/benchmarks/v6/


Changes from Version 5 to Version 6
===================================

Removed dead code from the RayTrace benchmark and fixed a couple of
typos in the DeltaBlue implementation. Changed the Splay benchmark to
avoid converting the same numeric key to a string over and over again
and to avoid inserting and removing the same element repeatedly thus
increasing pressure on the memory subsystem. Changed the RegExp
benchmark to exercise the regular expression engine on different
input strings.

Furthermore, the benchmark runner was changed to run the benchmarks
for at least a few times to stabilize the reported numbers on slower
machines.

Comment 1

[Trevor Baker]

Attachment: apply our v5 changes to v6

-rename v6 tests with "as" extensions
-apply "intent" of changes we made to v5 js files back to these new v6 versions

Comment 2

[Trevor Baker]

Comment on attachment 496178 [details] [diff] [review]
apply our v5 changes to v6

patch is for benchmark repo

Comment 3

[Chris Peyer]

Comment on attachment 496178 [details] [diff] [review]
apply our v5 changes to v6

One more minor change for js/regexp.as was needed:

-var RegExp = new BenchmarkSuite('RegExp', 910985, [
+var RegRxp = new BenchmarkSuite('RegExp', 910985, [

due to compiler error:

[Compiler] Error #1151: A conflict exists with definition RegExp in namespace internal.
   v8.6/js/regexp.as, Ln 40, Col 5: 
   var RegExp = new BenchmarkSuite('RegExp', 910985, [

I'll push the patch with this minor change.

Comment 4

[Chris Peyer]

attachment 496178 [details] [diff] [review] pushed to benchmark repo changeset:   17:a5f7fa190d1e

Comment 5

[Chris Peyer]

Attachment: Update untyped, typed and optimized directories to 8.6

Checked in files were copies from v8.5 (see benchmark repo rev 999d1906556b).

Comment 6

[Chris Peyer]

Attachment: updated patch with changes to base.as in each dir

Comment 7

[Brent Baker]

Here is my crib sheet that I put together of what the changes are between v5 and v6:

tamarin/v8.6/js/base.as
- primer run
- make sure that enough samples have been taken, otherwise run longer

tamarin/v8.6/js/crypto.as
- change baseline

tamarin/v8.6/js/deltablue.as
- change baseline
- comment spelling fixes
- change this.direction to use ths.v2.mark instead of v1

tamarin/v8.6/js/earley-boyer.as
- change baseline
- remove null vals from setting up Benchmarks

tamarin/v8.6/js/raytrace.as
- change baseline
- remove getIntensity()
- remove Flog.RayTracer.Shape.BaseShape, which is the base type for
all shapes (required is AS3 land)

tamarin/v8.6/js/regexp.as
- updated header
- updated baseline
- added setup and teardown functions
- changed to run each regexp through a common compueInputVariants()
instead of direct execution

tamarin/v8.6/js/richards.as
- change baseline

tamarin/v8.6/js/splay.as
- change baseline
- GeneratePayloadTree() now is passed tag instead of key, this is a
string instead of a number
- InsertNewNode()  var the payload before the insert and cast the key
to String() in the GeneratePayloadTree() call
- add findMax
- findGreatestLessThan() comment and code update , equal no long checked

Comment 8

[Brent Baker]

Comment on attachment 496533 [details] [diff] [review]
updated patch with changes to base.as in each dir

comments provided via IM converstaion, new patch will be posted shortly with tweaks

Comment 9

[Chris Peyer]

Attachment: Updated patch incorporating changes from brents review

Fixed issues in splay with key now being a string in payloaddata.  Removed the optimization in optimized/splay since the key is a string.

Fixed some indentation issues in optimized/regexp.as

Comment 10

[Brent Baker]

Comment on attachment 496562 [details] [diff] [review]
Updated patch incorporating changes from brents review

nit: key needs to be removed from the PayloadData() in the optimized version
nit: remove indentation changes from regexp files for str5 and str14

Comment 11

[Chris Peyer]

Attachment: updated patch with brents nits

Addressed brents nits, fixed botched merge of optimized/splay.as.

Comment 12

[Chris Peyer]

Pushed to benchmarks repo: 

http://asteam.corp.adobe.com/hg/benchmarks/rev/9d1cc7f31bdf