617486 - Quota handling adds tab length to the wrong array element

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[Toby Elliott [:telliott]]

$this->_quota[1] += strlen($tab[1]);

should be

$this->_quota[0] += strlen($tab[1]);

The main visible impact of this is that tabs will not count towards displayed quota. Given their size, that shouldn't matter. In the long run, once we actually enable quota control, this will also mess with how often we refresh the quota from the db.

As I'm working on stringifying those anyway, I think it would be easiest just to store the quota as [size]:[date] rather than as an array, so the fix will just get folded into that change.

Comment 1

[Toby Elliott [:telliott]]

decided against stringification, since tarek may want to just use a universal layer for extracting these, and having one be different will just cause problems.

Comment 2

[Toby Elliott [:telliott]]

Attachment: adds the length of the tab to the right field in the quota

Comment 3

[Toby Elliott [:telliott]]

Attachment: adds tab length to the right quota field

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 496546 [details] [diff] [review]
adds tab length to the right quota field

We need tests for this.

Comment 5

[Tarek Ziadé (:tarek)]

Not sure what's the status of this (I don't see it applied) Assigning to Toby

nb: we don't worry anymore about php/python memcached exchanges

Comment 6

[Toby Elliott [:telliott]]

Fixed and pushed back in December