617546 - customization of jetpack widgets is not persistent

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Dietrich Ayala (:dietrich)]

move a widget from the add-on bar to the tab bar. restart. widget is in the add-on bar.

this is partially because the widget id is generated at runtime, using a different guid each time.

it's also because we insert the widget into the add-on bar every time, not the bar it was resettled in.

Comment 1

[Dietrich Ayala (:dietrich)]

also, when removing a widget, we remove it from the add-on bar, which fails when the location has been customized.

Comment 3

[Dietrich Ayala (:dietrich)]

I have a WIP patch for this, coming up soon.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Pull request 118

So first and third commits (8edc6255, 1434e065) fix bug mentioned in this bug.
Two others commits are about Bug 630307 (7b9b39f5) and Bug 635714 (bbdc86a1)

Comment 5

[Dietrich Ayala (:dietrich)]

Comment on attachment 516371 [details]
Pull request 118

Looks good so far! A few changes and questions though, see the inline comments on the pull request.

Comment 6

[Alexandre Poirot [:ochameau]]

Attachment: Pull request 118

I made messages and doc more scarier about widget.id
and I wrote a comment in pull request about jetpackID.

Comment 7

[Dietrich Ayala (:dietrich)]

Comment on attachment 519128 [details]
Pull request 118

this is just about there. sorry, but i remembered a few different things to update!

* check if there are widgets in the example addons, update those
* check if there are widgets in other docs or the tutorial, update those
* update the cfx init skeleton code (iirc it makes a widget)

Comment 8

[Alexandre Poirot [:ochameau]]

Attachment: Pull request 118

I've adressed your comments and search for widgets uses in examples, templates and documentation.

About first-install TODO, I've created bug 641511.

Comment 9

[Dietrich Ayala (:dietrich)]

Comment on attachment 519147 [details]
Pull request 118

fantastic, r=me. thanks for pushing on this!

Comment 10

[Alexandre Poirot [:ochameau]]

Landed:
https://github.com/mozilla/addon-sdk/commit/e2b1538c0ad4d408affaa2ca37f072af7b07a4c0

I had to keed direct control on addon bar visiblity:
https://github.com/ochameau/addon-sdk/commit/f05cb2b1a2d3beed6e72ff5f2f310ba009f38272
I call Firefox function to toggle addon-bar only on first-launch,
but all code that hide the toolbar has been removed.
Hiding is handled by Firefox code that watch addon install/uninstall.