Closed Bug 617699 Opened 9 years ago Closed 9 years ago

nsDOMFileReader::DispatchProgressEvent compares PRUint64 mReadTotal >= 0

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b9

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug)

Details

(Keywords: coverity)

Attachments

(1 file)

content/base/src/nsDOMFileReader.h
line 153 -- PRUint64 mReadTotal;

content/base/src/nsDOMFileReader.cpp (View Hg log or Hg annotations)
line 158 -- mReadTotal(0), mReadTransferred(0)
line 498 -- mReadTotal = 0;
line 522 -- mReadTotal = -1;
line 523 -- mFile->GetSize(&mReadTotal);
line 578 -- progress->InitProgressEvent(aType, PR_FALSE, PR_FALSE, mReadTotal >= 0,
line 579 -- mReadTransferred, PR_MAX(mReadTotal, 0));

557 nsDOMFileReader::DispatchProgressEvent(const nsAString& aType)
558 {
578   progress->InitProgressEvent(aType, PR_FALSE, PR_FALSE, mReadTotal >= 0,
579                               mReadTransferred, PR_MAX(mReadTotal, 0));
Attached patch proposalSplinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #496362 - Flags: review?(jonas)
Attachment #496362 - Flags: approval2.0?
Attachment #496362 - Flags: review?(jonas)
Attachment #496362 - Flags: review+
Attachment #496362 - Flags: approval2.0?
Attachment #496362 - Flags: approval2.0+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/d987ade28bca
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b9
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.