617768 - Switch from IPC-Pipe back to nsIProcess

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Crowd Extension, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As long as IPC-Pipe is not stable enough, we have decided to switch back to nsIProcess to execute the test-run. Even with the limitation that we will not be able to see test results immediately.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I have a mostly working solution, but still fight with the paths which have a blank in it. Somehow it doesn't work at all, and I don't even get a failure. Mozmill exits silently without any output. It needs further investigation I will do today.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

This patch removed everything which was needed for IPC_Pipe and replaces it with nsiProcess. For now we have a blocking call, which means the UI is frozen until the testrun has been finished. I will change that later, once we have the correct structure of the environment class. Right now it's not really clean.

Aaron, when you want to test this patch, please copy the mozmill-automation repository under "crowd" in your profile (same level as the mozmill-env).

Comment 3

[Aaron Train [:aaronmt]]

Henrik, I'd love to test this but I am struggling with understanding the directory structure required here to get things rolling. I've placed a file pointer, "[e-mail]" that points to a temporary location on my desktop with the repository, "C:\Users\Aaron Train\Desktop\mozmill-crowd\extension", and it registers the extension fine.

What needs to be renamed to 'crowd', and where do I place the directory mozmill-env?

I know I'm not structuring something right because I get an NS_ERROR_FILE_NOT_FOUND on click of a test run.

Help me out, and I'll test and review :)

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #3)
> What needs to be renamed to 'crowd', and where do I place the directory
> mozmill-env?

Create the crowd folder inside your profile. It has to contain the mozmill-env folder beside the mozmill-automation folder. That's all.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1.1

Updated patch which fixes merge conflicts from the downloader implementation.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed as:
https://github.com/whimboo/mozmill-crowd/commit/b98fe5cc60e70dd3fdc5ad6ed07dce459a11fa8e
https://github.com/whimboo/mozmill-crowd/commit/126af9ac3d2a0566ae5c0c335adc9aeaf7c81f43 (removal of left-over IPC-Pipe files)