Switch from IPC-Pipe back to nsIProcess

RESOLVED FIXED in 0.1

Status

Mozilla QA Graveyard
Mozmill Crowd Extension
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

unspecified

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
As long as IPC-Pipe is not stable enough, we have decided to switch back to nsIProcess to execute the test-run. Even with the limitation that we will not be able to see test results immediately.
(Assignee)

Updated

8 years ago
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
(Assignee)

Comment 1

8 years ago
I have a mostly working solution, but still fight with the paths which have a blank in it. Somehow it doesn't work at all, and I don't even get a failure. Mozmill exits silently without any output. It needs further investigation I will do today.
(Assignee)

Comment 2

8 years ago
Created attachment 496585 [details] [diff] [review]
Patch v1

This patch removed everything which was needed for IPC_Pipe and replaces it with nsiProcess. For now we have a blocking call, which means the UI is frozen until the testrun has been finished. I will change that later, once we have the correct structure of the environment class. Right now it's not really clean.

Aaron, when you want to test this patch, please copy the mozmill-automation repository under "crowd" in your profile (same level as the mozmill-env).
Attachment #496585 - Flags: review?(aaron.train)
Henrik, I'd love to test this but I am struggling with understanding the directory structure required here to get things rolling. I've placed a file pointer, "mozmill-crowd@qa.mozilla" that points to a temporary location on my desktop with the repository, "C:\Users\Aaron Train\Desktop\mozmill-crowd\extension", and it registers the extension fine.

What needs to be renamed to 'crowd', and where do I place the directory mozmill-env?

I know I'm not structuring something right because I get an NS_ERROR_FILE_NOT_FOUND on click of a test run.

Help me out, and I'll test and review :)
(Assignee)

Comment 4

8 years ago
(In reply to comment #3)
> What needs to be renamed to 'crowd', and where do I place the directory
> mozmill-env?

Create the crowd folder inside your profile. It has to contain the mozmill-env folder beside the mozmill-automation folder. That's all.
(Assignee)

Comment 5

8 years ago
Created attachment 496989 [details] [diff] [review]
Patch v1.1

Updated patch which fixes merge conflicts from the downloader implementation.
Attachment #496585 - Attachment is obsolete: true
Attachment #496989 - Flags: review?(aaron.train)
Attachment #496585 - Flags: review?(aaron.train)

Updated

8 years ago
Attachment #496989 - Flags: review?(aaron.train) → review+
(Assignee)

Comment 6

8 years ago
Landed as:
https://github.com/whimboo/mozmill-crowd/commit/b98fe5cc60e70dd3fdc5ad6ed07dce459a11fa8e
https://github.com/whimboo/mozmill-crowd/commit/126af9ac3d2a0566ae5c0c335adc9aeaf7c81f43 (removal of left-over IPC-Pipe files)
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.1
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.