617818 - Need to be able to pass an expected build ID into the update test script

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Automation, defect)

Description

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

We discussed this a bit yesterday, and I think we kind of agreed that taking it from the python script command line and sending it to the JS tests via the persisted object was the best bet. 

However, I'm not in love with any one solution, so long as I can send in the expected ID and verify it during the test. Whatever works, works.

Comment 1

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Henrik, going ahead and assigning to you per discussion yesterday. If that's premature, feel free to clear it.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #0)
> We discussed this a bit yesterday, and I think we kind of agreed that taking it
> from the python script command line and sending it to the JS tests via the
> persisted object was the best bet. 

Right. There will be another option for the command line script. In the tests itself we will only run this comparison when the persisted property has been set. The reason is that we don't want to break tests executed by other users, who do not work with any trigger message.

I will put it on my list to have it ready by early next week.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1 (tests)

Patch for the software-update module, which adds another check for a target build id if given via the command line.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1 (scripts)

Patch for the testrun_update automation script to accept a --target-buildid option and forward it to the update tests.

Comment 5

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 497222 [details] [diff] [review]
Patch v1 (tests)

Looks fine. 

I think in this case you could have gone with just "if (!info.target_buildid)" since that'd also skip past blank strings, but what's there is fine too.

Comment 6

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 497223 [details] [diff] [review]
Patch v1 (scripts)

Looks great! Thanks bunches for the patch.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #5)
> I think in this case you could have gone with just "if (!info.target_buildid)"
> since that'd also skip past blank strings, but what's there is fine too.

I think you wanted to say: "if (info.target_buildid)". That makes total sense! Thanks for catching it. I will checkin the updated patch.

Pushed both patches as:
http://hg.mozilla.org/qa/mozmill-automation/rev/b306e1053fcb
http://hg.mozilla.org/qa/mozmill-tests/rev/fd24cfe19aca

Comment 8

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Hah, yeah, I did. Thanks for the correction!