Created attachment 496368 [details] missing <url> * <Url> with type=text/html should be required ** if given, method should be in POST, GET ** template should start with http * xmlns should be in ('http://a9.com/-/spec/opensearch/1.0/', 'http://a9.com/-/spec/opensearch/1.1/', 'http://a9.com/-/spec/opensearchdescription/1.1/', 'http://a9.com/-/spec/opensearchdescription/1.0/')
https://github.com/jbalogh/zamboni/commit/0f51723e7189 has tests and files that might be useful.
I'm going to also say that the type can equal application/xhtml+xml, as that covers XHTML.
It is also worth asking: do we support OpenSearch 1.0? If we do, then we need to put in support for attribute-less <Url></Url>s: http://www.opensearch.org/Documentation/OpenSearch_1.0_to_1.1_upgrade_guide#Modify_the_.22Url.22_element Perhaps we should just ban the two 1.0 xmlns?
Here's my changes: https://github.com/mattbasta/amo-validator/commit/a8ec8fe14fba0103d205f1279e2718a3521cfa89 I've added everything you mentioned, let me know what you want to do about the OpenSearch 1.0 stuff.
Thanks. (In reply to comment #4) > I've added everything you mentioned, let me know what you want to do about the > OpenSearch 1.0 stuff. I don't care about supporting anything weird. Remora requires text/html and a url with an http template, so we don't need to try hard to support OS1.0. The only thing zamboni cares about is having ShortName and Description. All the other checks are just nice things we're doing for developers.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.