first-letter/617869-1.html reftest fails due to inconsistent baseline of font-size:200% first-letter

NEW
Unassigned

Status

()

8 years ago
3 months ago

People

(Reporter: karlt, Unassigned)

Tracking

({testcase})

Trunk
testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

(Reporter)

Description

8 years ago
+++ This bug was initially created as a clone of Bug #553981 +++

Changes to gfxPlatform::SetupClusterBoundaries in bug 553981 fixed layout/reftests/first-letter/329069-2.html with CoreText but not with Uniscribe (same issue as Bug 615445, I assume) or DWrite.
(Reporter)

Comment 1

8 years ago
Created attachment 496466 [details]
WINNT 5.2 reftest failure

Windows Server 2003 doesn't have font support, but that's not really an excuse for getting the clusters wrong.
(Reporter)

Comment 2

8 years ago
Created attachment 496556 [details]
WINNT 6.1 reftest failure

The failure with DWrite shaping is just a baseline position difference and so not related to shaping/fonts but first-letter implementation.
Add lang="ko" (to improve font-selection) and an additional (not-first-letter) character does not correct the difference.
(Reporter)

Comment 3

8 years ago
The baseline difference is not there when font-size:200% is removed.
Summary: first-letter still splits up Hangul Jamo sequences → first-letter/329069-2.html reftest fails due to inconsistent baseline of font-size:200% first-letter
(Reporter)

Comment 4

8 years ago
Created attachment 496578 [details] [diff] [review]
separate first-letter font-size test
(In reply to comment #1)
> Created attachment 496466 [details]
> WINNT 5.2 reftest failure
> 
> Windows Server 2003 doesn't have font support, but that's not really an excuse
> for getting the clusters wrong.

The patch in bug 615445 (attachment 496786 [details] [diff] [review]) should fix the cluster issue on Win2k3/XP. (It doesn't address the baseline discrepancy, though, so the test with font-size will still fail.)
OS: Windows 7 → Windows XP

Comment 7

8 years ago
Gah sorry wrong bug...
(Reporter)

Comment 8

8 years ago
(In reply to comment #1)
> Windows Server 2003 doesn't have font support, but that's not really an excuse
> for getting the clusters wrong.

I think CompressedGlyph::SetMissing should not be overwriting FLAG_NOT_CLUSTER_START:
http://hg.mozilla.org/mozilla-central/annotate/61361e67bfc4/gfx/thebes/gfxFont.h#l1786
(Reporter)

Updated

8 years ago
Blocks: 618870
(Reporter)

Comment 9

8 years ago
> I think CompressedGlyph::SetMissing should not be overwriting
> FLAG_NOT_CLUSTER_START:

Spun off into Bug 618870.
(Reporter)

Comment 10

8 years ago
Separated the font-size test, so we have a passing Hangul Jamo test on WINNT 6.1.
http://hg.mozilla.org/mozilla-central/rev/bac79600ed97
(Reporter)

Updated

8 years ago
Summary: first-letter/329069-2.html reftest fails due to inconsistent baseline of font-size:200% first-letter → first-letter/617869-1.html reftest fails due to inconsistent baseline of font-size:200% first-letter
(Reporter)

Comment 11

8 years ago
Created attachment 497287 [details]
WINNT 6.1 reftest failure

Failures are similar on WINNT 5.2 and Mac, suggesting this might be a layout bug and perhaps Linux/FreeType is just getting lucky.
Attachment #496466 - Attachment is obsolete: true
Attachment #496556 - Attachment is obsolete: true
(Reporter)

Updated

8 years ago
OS: Windows XP → All
(Reporter)

Updated

8 years ago
Attachment #496886 - Attachment is obsolete: true

Comment 12

3 months ago
Test is:

https://dxr.mozilla.org/mozilla-central/source/layout/reftests/first-letter/617869-1.html

and then click the Raw link in the righthand side column


Reference file is:

https://dxr.mozilla.org/mozilla-central/source/layout/reftests/first-letter/617869-1-ref.html

and then click the Raw link in the righthand side column



When I try such test with Firefox 52.8.0 ESR (under Linux Debian 9.4, 64-bit), I get exactly the reference file.

WORKSFORME
Keywords: testcase
You need to log in before you can comment on or make changes to this bug.