617876 - Fix up theme code from bug 601183

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Most notably, hard-coded rgb values and descendent selectors should usually be avoided. There's code duplication too.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 496443 [details] [diff] [review]
patch

Thanks, I should have paid more attention to this.

>diff --git a/toolkit/themes/gnomestripe/global/webConsole.css b/toolkit/themes/gnomestripe/global/webConsole.css

>+.jsterm-input-node,
>+.jsterm-complete-node {

>+  padding: 0 0 0 16px;

Should this use -moz-padding-end? I guess these are forced LTR?

>+.jsterm-input-node {
>+  width: 98%;

Is this needed? The other themes don't seem to have it, not sure what it's supposed to do...

Comment 2

[Dão Gottwald [:dao]]

(In reply to comment #1)
> Should this use -moz-padding-end? I guess these are forced LTR?

Yes, this always LTR.

> Is this needed? The other themes don't seem to have it, not sure what it's
> supposed to do...

I have no idea why it's there either...

Comment 3

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/9c76b830138b