617880 - mark DEBUG only variables as ifdef DEBUG in mailnews

Status: RESOLVED WONTFIX

(MailNews Core :: Backend, defect)

Description

[timeless]

this is part of a crusade to get rid of compilation warnings

see bug 577899 for the explanation of the patch style

Comment 1

[timeless]

Attachment: patch

Comment 2

[David :Bienvenu]

Comment on attachment 496457 [details] [diff] [review]
patch

For me, this really reduces the readability of the code. I suspect most of these warnings would be fixed by handling the errors better, perhaps even logging them appropriately.

Comment 3

[David :Bienvenu]

Comment on attachment 496457 [details] [diff] [review]
patch

per previous comment, I'd like to have the warnings around so that we can deal with the underlying issues...

Comment 4

[timeless]

well, i'm not going to do this. i'm starting to clean out my bug list.

Comment 5

[Magnus Melin [:mkmelin]]

->WONTFIX as such, per previous comments.

Comment 6

[:aceman]

The patch even is strange:
   if (!m_incomingServer) {
     // ignore the error (and return null), but it's still bad so assert
-    nsresult rv = createIncomingServer();
+#ifdef DEBUG
+    nsresult rv =
+#endif
+    createIncomingServer();
     NS_WARN_IF_FALSE(NS_SUCCEEDED(rv), "couldn't lazily create the server\n");
   }

Do constructs like this even compile when rv is undefined in non-DEBUG case?