Closed Bug 617889 Opened 10 years ago Closed 10 years ago

warning: value computed is not used in porter_stemmer

Categories

(MailNews Core :: Search, defect)

Product:
MailNews Core
Component:
Search
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 3.3a2

People

(Reporter: timeless, Assigned: timeless)

Details

Attachments

(1 file, 1 obsolete file)

styled
4.26 KB, patch
timeless
: review+
Details | Diff | Splinter Review 
mailnews/extensions/fts3/src/fts3_porter.c: In function ‘porter_stemmer’:
625: warning: value computed is not used
629: warning: value computed is not used
642: warning: value computed is not used
647: warning: value computed is not used
653: warning: value computed is not used
658: warning: value computed is not used
667: warning: value computed is not used
674: warning: value computed is not used
717: warning: value computed is not used
737: warning: value computed is not used
Attached patch tell the compiler we don't care (obsolete) — — Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #496462 - Flags: review?(bienvenu)
Comment on attachment 496462 [details] [diff] [review]
tell the compiler we don't care

Thx for the patch. I'd much prefer this formatting:

     (void) (stem(&z, "lanoita", "ate", m_gt_0) ||
             stem(&z, "lanoit", "tion", m_gt_0));

since it saves a couple extra lines, which makes it easier to read the code.

r=me, with that addressed.
Attachment #496462 - Flags: review?(bienvenu) → review+
Attached patch styled — — Splinter Review
Attachment #496462 - Attachment is obsolete: true
Attachment #496614 - Flags: review+
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/b515ba820504
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a2
You need to log in before you can comment on or make changes to this bug.