617916 - XPCWrappedNativeScope::SystemIsBeingShutDown does not check ac.enter for failure

Status: RESOLVED INVALID

(Core :: XPConnect, defect)

Description

[timeless]

according to coverity there are 112 calls to JSAutoEnterCompartment::enter, and this is the only one which doesn't check the result:

662 XPCWrappedNativeScope::SystemIsBeingShutDown(JSContext* cx)
663 {

688     for(cur = gDyingScopes; cur; cur = cur->mNext)
689     {

694         JSAutoEnterCompartment ac;
695 
696         // XXX: What if we have no global in the scope???
697         if (cur->mGlobalJSObject)
698             ac.enter(cx, cur->mGlobalJSObject);

Comment 1

[Andrew McCreight [:mccr8]]

It looks like this method doesn't have JSAutoEnterCompartment any more, if that's even still a thing.

Comment 2

[Bobby Holley (:bholley)]

(In reply to Andrew McCreight [:mccr8] from comment #1)
> It looks like this method doesn't have JSAutoEnterCompartment any more, if
> that's even still a thing.

Yeah, it became JSAutoCompartment when it became infallible.