XPCWrappedNativeScope::SystemIsBeingShutDown does not check ac.enter for failure

RESOLVED INVALID

Status

()

RESOLVED INVALID
8 years ago
5 months ago

People

(Reporter: timeless, Unassigned)

Tracking

(Blocks: 1 bug, {coverity})

Trunk
coverity
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

8 years ago
according to coverity there are 112 calls to JSAutoEnterCompartment::enter, and this is the only one which doesn't check the result:

662 XPCWrappedNativeScope::SystemIsBeingShutDown(JSContext* cx)
663 {

688     for(cur = gDyingScopes; cur; cur = cur->mNext)
689     {

694         JSAutoEnterCompartment ac;
695 
696         // XXX: What if we have no global in the scope???
697         if (cur->mGlobalJSObject)
698             ac.enter(cx, cur->mGlobalJSObject);
It looks like this method doesn't have JSAutoEnterCompartment any more, if that's even still a thing.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INVALID
(In reply to Andrew McCreight [:mccr8] from comment #1)
> It looks like this method doesn't have JSAutoEnterCompartment any more, if
> that's even still a thing.

Yeah, it became JSAutoCompartment when it became infallible.
You need to log in before you can comment on or make changes to this bug.