618009 - add test for storage format detection during login

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Philipp von Weitershausen [:philikon]]

We're bumping to storage format 5 for crypto changes. Ugprading a storage version 4 account gives me "Wrong Sync Key" rather than the outdated notification. Looks like the fix in bug 614737 wasn't much effective.

I think to save storage version 4 users we need to choose a different WBO for storage format 5. But we also need to make sure we will never run into this ever again by checking the storage version during login. (Login checks for HTTP 200/401 on info/collections, perhaps we can just switch it to meta/global and then analyze the contents on a 200. That way we don't have to fetch it separtely.)

Comment 1

[Richard Newman [:rnewman]]

Proposed name for new WBO:

  storage/crypto/bulkkeys

? Or should we change the collection, also? Better name suggestions welcome.

Working on earlier check and test harness for it now.

Comment 2

[Ragavan S [:rags]]

Will Firefox Home need to do something here as well?

Comment 3

[Mike Connor [:mconnor]]

changing the collection makes this change much bigger, but maybe this looks like it's for the "bulkkeys" collection?

Could use "keys" instead.  keys/bulk for shortness win.a

Firefox Home will need to look for the new path, yes, so we need to lock that down first.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Firefox Home correctly checks the storage version before syncing. Including for v4 vs v5 in Home 1.1

CHanges to Home only need to be made if we muck with names for records.

Comment 5

[Richard Newman [:rnewman]]

Attachment: Test for 'busted' server with higher version, v1

The attached test passes for me. Philipp is double-checking his repro.

Comment 6

[Philipp von Weitershausen [:philikon]]

I can't reproduce anymore. Must've been a messed up profile or something.

Comment 7

[Richard Newman [:rnewman]]

Can't reproduce, but I still want to add this test.

Comment 8

[Richard Newman [:rnewman]]

Pushed: 

http://hg.mozilla.org/services/fx-sync/rev/4e55a139a835