61802 - javascript strict warnings in FilterEditor.js

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect, P3)

Description

[Henrik Gemal]

JavaScript strict warning:
chrome://messenger/content/FilterEditor.js line 216: redeclaration of var str

JavaScript strict warning:
chrome://messenger/content/FilterEditor.js line 48: reference to undefined 
property args.filter

JavaScript strict warning:
chrome://messenger/content/FilterEditor.js line 53: assignment to undeclared 
variable gFilterList

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

When you fix this, can someone verify, thanks!

Comment 2

[Mark Olson]

Attachment: patch - fix strict warnings, exorcise tabs

Comment 3

[Mark Olson]

Attachment: patch - incorporate some feedback from jag

Comment 4

[Peter "jag" Annema]

r=jag.

Comment 5

[Mark Olson]

cc'ing sspitzer for sr

Comment 6

[(not reading, please use [e-mail] instead)]

I'd like the module owner (gayatrib) to review and test before I super review
this.

Comment 7

[(not reading, please use [e-mail] instead)]

no objection to you fixing whitespace, thanks for doing it.

but can you attach a patch made with "cvs -q diff -uw" so I can focus on the
important changes?

Comment 8

[Mark Olson]

Attachment: patch - for review use only

Comment 9

[Mark Olson]

Seth, here's a -uw, but it also includes some unrelated stringbundle migration
that can be ignored (sorry, i don't have a version other than the previously
attached patch w/o the stringbundle stuff)

Comment 10

[Peter "jag" Annema]

Attachment: [patch] same patch without stringbundle changes

Comment 11

[Peter "jag" Annema]

my r= still stands, btw :-)

Comment 12

[(not reading, please use [e-mail] instead)]

thanks mark, that makes it much easier to review.

one request, removing dumps is good, but some of those dump looks like they can
be made into useful comments.

the simplest thing would be to comment them out instead of removing them.

Comment 13

[Mark Olson]

Attachment: -wu w/ dump -> comment changes

Comment 14

[Mark Olson]

Attachment: -u of same

Comment 15

[(not reading, please use [e-mail] instead)]

patch looks good to me.  thanks mark.

sr=sspitzer

Comment 16

[timeless]

looks good

Comment 17

[timeless]

fix checked in

Comment 18

[[e-mail] (gone - use [e-mail] instead)]

Verified FIXED.  I didn't see any of the JS errors that are as filed from
Henrik, when setting up and editing a Bugmail filter.