VMCFG_PRECOMP_NAMES has very little use

RESOLVED FIXED

Status

Tamarin
Virtual Machine
--
trivial
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Krzysztof Palacz, Assigned: Krzysztof Palacz)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Another candidate for simplification, it's defined when either the jit or the wordcode interpreter is enabled. By disabling this switch we trade time for space in bytecode-interpreter-only configurations, which are not relevant.
(Assignee)

Comment 1

7 years ago
Created attachment 496547 [details] [diff] [review]
Permanently turns on code predicated on VMCFG_PRECOMP_NAMES.
Assignee: nobody → kpalacz
Attachment #496547 - Flags: review?(lhansen)

Updated

7 years ago
Attachment #496547 - Flags: review?(lhansen) → review+

Comment 2

7 years ago
changeset: 5674:0f3e3b021435
user:      kpalacz@adobe.com
summary:   Bug 618026 - VMCFG_PRECOMP_NAMES has very little use (r+lhansen)

http://hg.mozilla.org/tamarin-redux/rev/0f3e3b021435
(Assignee)

Comment 3

7 years ago
Had to rerun exactgc.as to fully get rid of the define (committed the generated file as well).
Worth remembering that when #defines change, the tracer code may need an update.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.