618057 - Fix avmplus and MMgc projects to be stricter

Status: RESOLVED FIXED

(Tamarin Graveyard :: Build Config, defect, P2)

Description

[Tommy Reilly]

The reason we keep running into warning problems with flash is that they add /Wall as well as disabling more specific warnings.   We should do that to our avmplus and MMgc projects too.

Comment 1

[Tommy Reilly]

Attachment: Use platform appropriate typedef for vmpi_thread_t

Comment 2

[Tommy Reilly]

Comment on attachment 497884 [details] [diff] [review]
Use platform appropriate typedef for vmpi_thread_t

This fixes /Wall warnings on void*/DWORD casts

Comment 3

[Lars T Hansen]

Comment on attachment 497884 [details] [diff] [review]
Use platform appropriate typedef for vmpi_thread_t

Seems plausible.

Comment 4

[Tamarin Bot]

changeset: 5683:02eda265f1a6
user:      Tommy Reilly <[e-mail]>
summary:   Bug 618057 - Fix avmplus and MMgc projects to be stricter, first fix some warnings aroud vmpi_thread_t (r=lhansen)

http://hg.mozilla.org/tamarin-redux/rev/02eda265f1a6

Comment 5

[Tamarin Bot]

changeset: 5684:72d4904a24a6
user:      Tommy Reilly <[e-mail]>
summary:   Bug 618057 - Missing from previous change, remove now unnecessary casts (r=lhansen)

http://hg.mozilla.org/tamarin-redux/rev/72d4904a24a6

Comment 6

[Tommy Reilly]

Attachment: Fix void*/uint64_t warning problem

Comment 7

[Tommy Reilly]

Attachment: Capstone: Make our projects strict like the players

Comment 8

[Tamarin Bot]

changeset: 5685:af5a02cdc698
user:      Tommy Reilly <[e-mail]>
summary:   Bug 618057 - More vmpi_thread_t cleanup

http://hg.mozilla.org/tamarin-redux/rev/af5a02cdc698

Comment 9

[Lars T Hansen]

Comment on attachment 498114 [details] [diff] [review]
Fix void*/uint64_t warning problem

Rubber stamp, I don't really know this code.

Comment 10

[Lars T Hansen]

Comment on attachment 498118 [details] [diff] [review]
Capstone: Make our projects strict like the players

I'd probably be more comfortable if those warnings were disabled in the code, along with all the other ones, in the windows platform directory, than in the project file.  (win32-platform.h)

Comment 11

[Tommy Reilly]

In reply to comment #10)
> Comment on attachment 498118 [details] [diff] [review]
> Capstone: Make our projects strict like the players
> 
> I'd probably be more comfortable if those warnings were disabled in the code,
> along with all the other ones, in the windows platform directory, than in the
> project file.  (win32-platform.h)

Yeah me too but that doesn't work, enabling /Wall makes the system headers start to throw warnings so disabling them in win32-platform.h doesn't work.

Comment 12

[Simon Wilkinson]

Comment on attachment 497884 [details] [diff] [review]
Use platform appropriate typedef for vmpi_thread_t


A belated f+

This reminds me though, we assume that vmpi_thread_t's can be compared with == on all our platforms. This clearly holds at the moment, but at some stage we may want to think about using pthread_equals instead.

Comment 13

[Tamarin Bot]

changeset: 5686:eacb19258e91
user:      Tommy Reilly <[e-mail]>
summary:   Bug 618057 - fix linux warnings 0 is the right value for an uninitlized thread, not NULL

http://hg.mozilla.org/tamarin-redux/rev/eacb19258e91

Comment 14

[Tamarin Bot]

changeset: 5687:f4809ce0c7de
user:      Tommy Reilly <[e-mail]>
summary:   Bug 618057 - fix uint64_t/void* casting problems in Sampler (r=lhansen)

http://hg.mozilla.org/tamarin-redux/rev/f4809ce0c7de

Comment 15

[Tamarin Bot]

changeset: 5688:8b0f0206ca36
user:      Tommy Reilly <[e-mail]>
summary:   Bug 618057 - Update project files to match the player, Wall with more DisableSpecificWarnings (r=lhansen)

http://hg.mozilla.org/tamarin-redux/rev/8b0f0206ca36