618171 - offer to associate a bug to a failed test result

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: MozTrap, enhancement, P1)

Description

[Aakash Desai [:aakashd]]

Attachment: add a bug

When a user select "failed" as the result of a testcase, a "add a bug" user interface should pop-down below the test case. In there, users should be able to add:

* The id of a new bug
* Select an already filed bug for the testcase version

To add a new bug, the "add" button should be clicked. After the click, an id entered and submit button should show. After the id is entered, the submit button will request the title of the bug and those fields will be added to bugs associated to the test result.

Comment 1

[Carl Meyer (:carljm)]

Ok, so we'll need this capability added to the API, it isn't currently there.

Comment 2

[Cameron Dawson [:camd]]

A Pivotal Tracker story has been created for this Bug: http://www.pivotaltracker.com/story/show/12752431

Comment 3

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
api bug: https://bugzilla.mozilla.org/show_bug.cgi?id=656710

Comment 4

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
platform bug resolved.  so this should be cleared now.

Comment 5

[Cameron Dawson [:camd]]

Eric Meyer changed story state to started in Pivotal Tracker

Comment 6

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
I think this is great.  I also thing, though, that the bug items listed should be live URLs, (if they are in URL format) so that the user can nav to them to check if they're the one they intend.  would you like a separate story for that?

Comment 7

[Cameron Dawson [:camd]]

Jonny Gerig Meyer added a comment in Pivotal Tracker:   
   
Carl: When I assign a new bug, it shows up after ajax-reload. But when I assign an existing bug, it doesn't show up. Shouldn't it?

Comment 8

[Cameron Dawson [:camd]]

Carl Meyer added a comment in Pivotal Tracker:   
   
jonny: yes it should, but it doesn't at the moment due to this platform issue: https://www.pivotaltracker.com/story/show/19109777

Comment 9

[Cameron Dawson [:camd]]

Carl Meyer changed story state to finished in Pivotal Tracker

Comment 10

[Cameron Dawson [:camd]]

Carl Meyer changed story state to delivered in Pivotal Tracker

Comment 11

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
Not sure who this belongs to: if I had entered some NON url text for the url of the bug (like just a bug number) it still treats it as a URL.  However, it looks like it just appends that to a CC URL.

I entered: 23425323
the url it ended up with was: https://cc-dev.oddsites.net/run/4/23425323

Could we check if the value is a valid URL?  If not, just make it static text?

Comment 12

[Cameron Dawson [:camd]]

Cameron Dawson changed story state to rejected in Pivotal Tracker

Comment 13

[Cameron Dawson [:camd]]

Carl Meyer changed story state to started in Pivotal Tracker

Comment 14

[Cameron Dawson [:camd]]

Carl Meyer added a comment in Pivotal Tracker:   
   
eric: this needs some styling help now that bugs are not necessarily links. see bugs/bug.html if you need to make markup changes; note that the radio-button-list in _run_case.html doesn't use that template.

Comment 15

[Cameron Dawson [:camd]]

Eric Meyer added a comment in Pivotal Tracker:   
   
cam: I'm wondering about this as a UI choice. Why do we want to allow non-URL bugs?

Comment 16

[Cameron Dawson [:camd]]

Eric Meyer added a comment in Pivotal Tracker:   
   
carl: we're dropping support for non-urls. the input is already a url input, so it should HTML5-validate as such. not sure why it isn't. back to you.

Comment 17

[Cameron Dawson [:camd]]

Carl Meyer added a comment in Pivotal Tracker:   
   
@j this is in 0.5.X-runtests-form

Comment 18

[Cameron Dawson [:camd]]

Carl Meyer added a comment in Pivotal Tracker:   
   
I know it doesn't seem related to this bug, but the URL-validation stuff here is actually why I'm doing it, so it is.

Comment 19

[Cameron Dawson [:camd]]

Carl Meyer added a comment in Pivotal Tracker:   
   
@j - on that branch, the server-side now also validates required fields and returns errors as messages, more like other parts of the site. So all that JS custom validation isn't needed anymore (it's kinda broken anyway, repeated errors show up multiple times and never disappear). HTML5 form validation (which will now work) is enough to have on the client-side, if they don't have a new enough browser for that they'll just get it in messages.

Comment 20

[Cameron Dawson [:camd]]

Carl Meyer changed story state to finished in Pivotal Tracker

Comment 21

[Cameron Dawson [:camd]]

Carl Meyer changed story state to delivered in Pivotal Tracker

Comment 22

[Cameron Dawson [:camd]]

Cameron Dawson changed story state to accepted in Pivotal Tracker