Closed
Bug 618185
Opened 14 years ago
Closed 5 years ago
Update breakpad.reportURL URL to crash-stats.mozilla.org
Categories
(Toolkit :: Crash Reporting, task)
Toolkit
Crash Reporting
Tracking
()
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: reed, Assigned: gsvelto, Mentored)
References
Details
(Whiteboard: [lang=js])
Attachments
(2 files)
The URL for crash-stats is changing in bug 618153 from crash-stats.mozilla.com to crash-stats.mozilla.org. Need to update all the various toolkit apps to use the new hostname.
Comment 1•14 years ago
|
||
I don't think we should bother changing the serverURL unless there's some real pressing concern. (It's set to crash-reports.mozilla.com, FWIW.) We can change breakpad.reportURL, though which is how we generate the links from about:crashes: http://mxr.mozilla.org/mozilla-central/source/browser/app/profile/firefox.js#869
Reporter | ||
Comment 2•14 years ago
|
||
Ah, that's even better.
Summary: Update breakpad server URL to crash-stats.mozilla.org → Update breakpad.reportURL URL to crash-stats.mozilla.org
Comment 3•12 years ago
|
||
Also change it to https please :)
Comment 4•12 years ago
|
||
Why? This is strictly for generating the links within about:crashes.
Comment 5•12 years ago
|
||
For performance (the server redirects to https) and privacy (of the connection between the crash report and the user), mostly.
Updated•11 years ago
|
Whiteboard: [mentor=ted][lang=javascript]
Updated•10 years ago
|
Whiteboard: [mentor=ted][lang=javascript] → [good first bug][mentor=ted][lang=javascript]
I am interested in working on this bug, Can I get this assigned to me?
Comment 7•10 years ago
|
||
Sure! The relevant location in the source is: http://hg.mozilla.org/mozilla-central/annotate/879038dcacb7/browser/app/profile/firefox.js#l939
Assignee: nobody → gillh11
Updated•10 years ago
|
Assignee: nobody → abhishekp.bugzilla
Comment 10•10 years ago
|
||
Attachment #8394694 -
Flags: feedback?(ted)
Updated•10 years ago
|
Status: NEW → ASSIGNED
Comment 11•10 years ago
|
||
Comment on attachment 8394694 [details] [diff] [review] bug-618185-fix.diff Review of attachment 8394694 [details] [diff] [review]: ----------------------------------------------------------------- This looks fine, thanks!
Attachment #8394694 -
Flags: feedback?(ted) → review+
Comment 12•10 years ago
|
||
is this bug fixed ? actually I am newbie and I need to start from some bug if its not fixed can someone assigned me this bug ?
Comment 13•10 years ago
|
||
This bug is ASSIGNED, which means someone is working on it. In fact it already has a reviewed patch, which means it's basically done.
Keywords: checkin-needed
Reporter | ||
Comment 14•10 years ago
|
||
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #13) > This bug is ASSIGNED, which means someone is working on it. In fact it > already has a reviewed patch, which means it's basically done. This can't land until the SSL cert on crash-stats.m.o is modified to include .m.o besides .m.c.
Updated•10 years ago
|
Mentor: ted
Whiteboard: [good first bug][mentor=ted][lang=javascript] → [good first bug][lang=javascript]
Updated•10 years ago
|
Whiteboard: [good first bug][lang=javascript] → [good first bug][lang=js]
Comment 16•10 years ago
|
||
Hi, Can I start work on this bug please? Thanks David
Comment 17•10 years ago
|
||
It looks like this bug is basically finished; we're just waiting on some website infrastructure changes before we can commit the patch up above.
Updated•9 years ago
|
Whiteboard: [good first bug][lang=js] → [lang=js]
Comment 18•9 years ago
|
||
(In reply to Josh Matthews [:jdm] from comment #17) > It looks like this bug is basically finished; we're just waiting on some > website infrastructure changes before we can commit the patch up above. The infrastructure for .org is now in place and verified working.
Assignee | ||
Comment 19•5 years ago
|
||
Ted, do we still want to make this change? The code still uses the .com version so either we switch to .org or close this.
Flags: needinfo?(ted)
Comment 20•5 years ago
|
||
I would like it if we made this change. We've got bug #1322412 covering dropping the .com versions of things in the Socorro product. It'd be nice to start that ball rolling.
Blocks: 1322412
Assignee | ||
Comment 21•5 years ago
|
||
OK, this is a trivial fix. The HTTPS certificate is the same for both .com and .org right?
Assignee | ||
Updated•5 years ago
|
Assignee: abhishekp.bugzilla → gsvelto
Comment 22•5 years ago
|
||
Miles: Can you answer the question about the certificate? ^^^
Flags: needinfo?(miles)
Assignee | ||
Comment 23•5 years ago
|
||
It's currently pinned [1] to the certificate used by other services [2]. I assume it's the same but better safe than sorry. [1] https://searchfox.org/mozilla-central/source/security/manager/tools/PreloadedHPKPins.json#213-214 [2] https://searchfox.org/mozilla-central/source/security/manager/tools/PreloadedHPKPins.json#73
Comment 24•5 years ago
|
||
The certificate in place covers both crash-stats.mozilla.com and crash-stats.mozilla.org and those cert pins are correct.
Flags: needinfo?(miles)
Assignee | ||
Comment 25•5 years ago
|
||
Comment 26•5 years ago
|
||
Pushed by gsvelto@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ec4b2e77d693 Switch the default URL for sending crash reports to the *.mozilla.org domain r=ted
Comment 27•5 years ago
|
||
Hooray! Now we just need to wait a few years and we can drop the crash-stats.mozilla.com. Thank you!
Comment 28•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ec4b2e77d693
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Updated•5 years ago
|
Flags: needinfo?(ted)
Updated•5 years ago
|
Type: defect → task
You need to log in
before you can comment on or make changes to this bug.
Description
•