Closed Bug 618277 Opened 9 years ago Closed 9 years ago

It is no longer possible to left align the status bar shim in the addons bar

Categories

(Firefox :: Toolbars and Customization, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 4.0b8

People

(Reporter: pwd.mozilla, Assigned: dao)

References

Details

(Whiteboard: [addon bar])

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101210 Firefox/4.0b8pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101210 Firefox/4.0b8pre

As a user, all of my primary buttons were aligned to the right. The only things I had aligned to the left were the RSS Icon and the status bar shim. Both were managed courtesy of a flexible spacer. I can no longer achieve this designed effect.

Reproducible: Always
Blocks: 574688, 616014
Version: unspecified → Trunk
You've tried 'Restore Default Set', yes?
I've tried 'Restore Default Set' and as such I can now right align items but can't left align items.
From my comment in the other bug:

The right alignment bug happens if you have a flexible space in the addon-bar.
An easy way to fix it is by opening localstore.rdf and adding "addonbar-"
infront of "spring" in the list of items under the addon-bar (search for
browser.xul#addon-bar and look under currentset).
Dropping items on the left side of the add-on bar seems to work just fine for me.
(In reply to comment #4)
> Dropping items on the left side of the add-on bar seems to work just fine for
> me.

How are you achieving this Dao? I'm attempting to use the flexible spacer and I'm getting no such luck.
Summary: It is no longer possible to right align buttons in the addons bar with the landing of Bug 616014 → It is no longer possible to left align buttons in the Addons Bar with the landing of Bug 616014
All I did was to restore the default set and drag an item to the left of the add-on bar. I'm not sure what you mean by "use the flexible spacer".
Summary: It is no longer possible to left align buttons in the Addons Bar with the landing of Bug 616014 → It is no longer possible to right align buttons in the addons bar with the landing of Bug 616014
When customizing the addon-bar you can add a flexible space to teh addon-bar which you can drag around all you want and place new stuff on both sides of it. 

The spacer added in the patch (addonbar-spring) isn't visible at all when customizing nor can it dragged anywhere. That is probably what is causing all the problems.
Ah, I see what you've done.

What I'm attempting to do is left align an icon along with the status bar shim.
This worked previously. However now, I'm unable to force the status bar shim to
the left using a flexible spacer from the customisation palette.
Summary: It is no longer possible to right align buttons in the addons bar with the landing of Bug 616014 → It is no longer possible to left align the status bar shim in the addons bar
Component: Theme → Toolbars
OS: Windows 7 → All
QA Contact: theme → toolbars
Hardware: x86 → All
Attached patch patchSplinter Review
This makes the spring (re)movable.
Assignee: nobody → dao
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #496808 - Flags: review?(dietrich)
Comment on attachment 496808 [details] [diff] [review]
patch

i don't understand - you put a spring in the currentset but not in the toolbar itself.
toolbar.xml creates springs automatically.
blocking2.0: --- → ?
Attachment #496808 - Flags: review?(dietrich)
Attachment #496808 - Flags: review+
Attachment #496808 - Flags: approval2.0+
http://hg.mozilla.org/mozilla-central/rev/dc366807e083
Status: ASSIGNED → RESOLVED
blocking2.0: ? → ---
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
Whiteboard: [addon bar]
You need to log in before you can comment on or make changes to this bug.