618300 - Easy Setup UI: "Device Connected" modal dialog has no OK/Close button

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Steffen Wilberg]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101210 Firefox/4.0b8pre

I used Sync's new easy setup UI on desktop and mobile to connect my phone (which has managed to disconnect for whatever reason).

The process worked like a charm, but at the end a "Device Connected" modal dialog stays open, which doesn't have an OK or Close button, just the red X window close button in its title bar.

This is a bit confusing: Am I allowed to close the dialog, which tells me that syncing may take a while? Does closing the dialog interrupt the sync? On the other hand, Firefox is blocked until you close it (or shift-click the Firefox icon in the windows task bar, which opens a new window).

Comment 1

[Steffen Wilberg]

Oh, I saw this in the Error Console:

2010-12-10 17:18:55	CollectionKeys       WARN	Got exception "[Exception... "cipher finalize failed"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://services-crypto/WeaveCrypto.js :: <TOP_LEVEL> :: line 557"  data: no]" decrypting storage keys with sync key.

2010-12-10 17:18:55	Service.Main         WARN	Got exception "[Exception... "cipher finalize failed"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://services-crypto/WeaveCrypto.js :: <TOP_LEVEL> :: line 557"  data: no]" fetching cryptoKeys.

2010-12-10 17:18:55	Service.Main         WARN	Failed to fetch symmetric keys. Failing remote setup.

Comment 2

[Philipp von Weitershausen [:philikon]]

(In reply to comment #1)
> Oh, I saw this in the Error Console:
> 
> 2010-12-10 17:18:55    CollectionKeys       WARN    Got exception
> "[Exception... "cipher finalize failed"  nsresult: "0x80004005
> (NS_ERROR_FAILURE)"  location: "JS frame ::
> resource://services-crypto/WeaveCrypto.js :: <TOP_LEVEL> :: line 557"  data:
> no]" decrypting storage keys with sync key.
> 
> 2010-12-10 17:18:55    Service.Main         WARN    Got exception
> "[Exception... "cipher finalize failed"  nsresult: "0x80004005
> (NS_ERROR_FAILURE)"  location: "JS frame ::
> resource://services-crypto/WeaveCrypto.js :: <TOP_LEVEL> :: line 557"  data:
> no]" fetching cryptoKeys.
> 
> 2010-12-10 17:18:55    Service.Main         WARN    Failed to fetch symmetric
> keys. Failing remote setup.

This is bug 618068. Can you please add a comment there with your sync log and your steps to reproduce (in other words, how you got to that state?) Thanks!

Comment 3

[Philipp von Weitershausen [:philikon]]

(In reply to comment #0)
> The process worked like a charm, but at the end a "Device Connected" modal
> dialog stays open, which doesn't have an OK or Close button, just the red X
> window close button in its title bar.

Oh hrm, yes, I can reproduce that... Thanks for reporting!

> This is a bit confusing: Am I allowed to close the dialog, which tells me that
> syncing may take a while? Does closing the dialog interrupt the sync? On the
> other hand, Firefox is blocked until you close it (or shift-click the Firefox
> icon in the windows task bar, which opens a new window).

Yes, you can close it. The Finish button is only missing on the "Add Device" dialog, not the "Setup Sync" dialog on the device that's doing the actual sync.

Comment 4

[Philipp von Weitershausen [:philikon]]

(In reply to comment #3)
> Yes, you can close it. The Finish button is only missing on the "Add Device"
> dialog, not the "Setup Sync" dialog on the device that's doing the actual sync.

(Also, you can close the dialog on the device that's doing the actual sync. Sync always works in the background.)

Comment 5

[Mike Connor [:mconnor]]

It's not optimal, but I wouldn't hold b8 on this.  Would take a low-risk fix.

Comment 6

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Put the wizard pages in a sane order, so that the Device Connected page is the last one and we get the Finish button for free.

Also make the Sync Key box selectable (readonly instead of disabled).

Comment 9

[LegNeato]

As per today's meeting, beta 9 will be a time-based release. Marking these all betaN+. Please move it back to beta9+ if you believe it MUST be in the next beta (ie: trunk is in an unshippable state without this)

Comment 10

[LegNeato]

Fixing fields my automated script accidentally blanked. Apologies for the bugspam

Comment 11

[Philipp von Weitershausen [:philikon]]

http://hg.mozilla.org/mozilla-central/rev/79d00f4cad73