618342 - Invalid sync key is accepted as correct one, then existing data is wiped

Status: RESOLVED INVALID

(Firefox :: Sync, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I have created an account with 3.6.12/1.5.1.

I then quit Firefox and run Minefield trunk (2010-12-10) and create a new empty
profile. I setup sync and enter the correct username and password but the INCORRECT sync key.

I see the "verifying" thing happening, without errors. Sync is then setup.

Sync proceeds to setup the account with the wrong sync key and wipes existing data, replacing it with empty data from the current (empty) profile.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: Weave log file

Comment 2

[Philipp von Weitershausen [:philikon]]

Yes, the new-crypto Sync does not verify the Sync Key because when it doesn not look at the old priv/pub keypair.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

This means you can not install 1.6 on a clean profile with an existing 1.5.1 account that has data in the cloud. I kind of assumed that it would do the initial sync by grabbing the v4 data and then push the upgraded v5 data back. I know we are not a backup service, but I don't think people expect to lose data when upgrading this way.

Comment 4

[Philipp von Weitershausen [:philikon]]

(In reply to comment #3)
> This means you can not install 1.6 on a clean profile with an existing 1.5.1
> account that has data in the cloud. I kind of assumed that it would do the
> initial sync by grabbing the v4 data and then push the upgraded v5 data back.

Nope. The client only ever supports one storage version at a time.

> I know we are not a backup service, but I don't think people expect to lose data
> when upgrading this way.

They're not losing data. The canonical data is not on the server, it's spread across all clients.

Comment 5

[Richard Newman [:rnewman]]

Pretty sure this is stale.