618360 - devicemanager needs to return an error if it's unable to connect to the device

Status: RESOLVED DUPLICATE of bug 624001

(Testing :: General, defect)

Description

[Aki Sasaki (not active)]

I'm seeing a lot of this:

python ../../sut_tools/cleanup.py 10.250.48.252
 in dir /builds/tegra-002/mozilla-central_tegra_android_test-remote-tpan/../talos-data (timeout 1800 secs)
connecting to: 10.250.48.252
reconnecting socket
unable to connect socket
reconnecting socket
unable to connect socket
reconnecting socket
unable to connect socket
program finished with exit code 0

This makes buildbot assume that everything happened successfully.  It should error out if it can't clean up.

This may be as simple as changing "sendCMD(blah)" to "return sendCMD(blah)", or maybe not.

The real fix may involve using the ini file to send heartbeat actively rather than polling for it.

Comment 1

[Aki Sasaki (not active)]

Also

connecting to: 10.250.51.242
reconnecting socket
unable to connect socket
reconnecting socket
unable to connect socket
It's a trap! devRoot [/tests] is not set correctly
/builds/tegra-005/talos-data/../proxy.flg
Installing/tests/fennec-4.0b3pre.en-US.eabi-arm.apk
devroot /tests
in push file with: ../talos-data/fennec-4.0b3pre.en-US.eabi-arm.apk, and: /tests/fennec-4.0b3pre.en-US.eabi-arm.apk
reconnecting socket
unable to connect socket
local hash returned: '004047ce45bf303b599a9e58de9c0176'
reconnecting socket
unable to connect socket
reconnecting socket
unable to connect socket
failed making directory: /tests
unable to make dirs: /tests/fennec-4.0b3pre.en-US.eabi-arm.apk
reconnecting socket
unable to connect socket
sharks with frickin laser beams attached to their heads

Comment 2

[Aki Sasaki (not active)]

and

Traceback (most recent call last):
  File "remotePerfConfigurator.py", line 198, in <module>
    reconnecting socket
unable to connect socket
reconnecting socket
unable to connect socket
reconnecting socket
unable to connect socket
sys.exit(main())
  File "remotePerfConfigurator.py", line 189, in main
    configurator = remotePerfConfigurator(options)
  File "remotePerfConfigurator.py", line 14, in __init__
    pc.PerfConfigurator.__init__(self, options)
  File "/builds/tegra-005/talos-data/talos/PerfConfigurator.py", line 180, in __init__
    self.buildid = self._getCurrentBuildId()
  File "/builds/tegra-005/talos-data/talos/PerfConfigurator.py", line 54, in _getCurrentBuildId
    masterContents = self._getMasterIniContents()
  File "remotePerfConfigurator.py", line 136, in _getMasterIniContents
    retVal = self.testAgent.getFile(remoteFile, localfilename)
  File "/builds/tegra-005/talos-data/talos/devicemanager.py", line 553, in getFile
    retVal = self.pullFile(remoteFile)
  File "/builds/tegra-005/talos-data/talos/devicemanager.py", line 500, in pullFile
    data = read(1024, 'could not find metadata')
  File "/builds/tegra-005/talos-data/talos/devicemanager.py", line 491, in read
    data = self._sock.recv(to_recv)
AttributeError: 'NoneType' object has no attribute 'recv'