618481 - Remove redundant code from es5.js

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Atul Varma [:atul]]

Irakli mentioned the following as a comment for the changes introduced by bug 614957:

1. There is no value in bookkeeping of descriptors maps , they ether can go away or we can probably move them under hidden properties on an instance itself. As it is now getOwnPropertyDescriptor isFrozen ... won't work across modules.
2. Also init function was there for passing natives form other sandboxes, which is irrelevant now and probably can go away.
3. Also my guess is that some tests will be broken on FF3.* so probably it will be good idea to remove those.

Also I guess my first 2 comments can be addressed in the follow up bug.

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/172

Pointer to Github pull-request

Comment 2

[Dietrich Ayala (:dietrich)]

Comment on attachment 534408 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/172

talked on irc, r=me w/ the change noted on the pull request.

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

https://github.com/mozilla/addon-sdk/commit/d581c40a24313b6606a98766f3106f1831180d40