wizardSkipPanels does not skip all panels

RESOLVED WORKSFORME

Status

SeaMonkey
MailNews: Account Configuration
RESOLVED WORKSFORME
18 years ago
10 years ago

People

(Reporter: BenB, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
If you create an ISP-RDF-file with all required info for a new account, you may
not want to bother the user with confirming it. Thus, you enable set
<NC:wizardSkipPanels>true</NC:wizardSkipPanels>

Expected:
After selecting that account, the wizard jumps directly to the confirmation pane
(the last one where the summary is shown).

Actual:
The Identity pane is displayed, prefilled with the values from the ISP file.
Only after clicking Next, the user gets to the confirmation pane.

Additional Comments:
- Is it a problem to change the behaviour of that flag? Or should I rename it to
wizardSkipServerPanels or similar and add wizardSkipAllPanels?
- I tried to change the sequence, but it only gets effective after the Identity
pane is already loaded. It seems like I'd have to change the generic wizard
functions. It might be easier to change the sequence as soon as the user changes
the radio selection in the account type pane. Any suggestions/advice?
(Reporter)

Comment 1

18 years ago
.
Assignee: sspitzer → ben.bucksch
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → mozilla0.9
(Reporter)

Updated

18 years ago
Status: NEW → ASSIGNED
(Reporter)

Comment 2

18 years ago
> It might be easier to change the sequence as soon as the user changes
> the radio selection in the account type pane.

Done. Was a 1-line change. No practically noticable performace decrease.
(Reporter)

Comment 3

18 years ago
> should I rename it to
> wizardSkipServerPanels or similar and add wizardSkipAllPanels?

Also done.

Please file a bug for Netscape to change the AOL and Netcenter ISP files in N6.x
to use "wizardSkipServerPanels" instead of "wizardSkipPanels" to achieve the
same effect as today. I change the same aol.rdf, just do a similar change for
your internal tree.

> It might be easier to change the sequence as soon as the user changes
> the radio selection in the account type pane.

To make it clear: With that change, we will (I think) read in the ISP file as
soon as and every time the user changed the selection to the corresponding entry
(e.g "AOL account", but not "ISP or email account" or "Newsgroup..."). I don't
know, if the read is cached. I didn't see a practical perf decrease on my
machine, but it is above-average, of course.

Will attach patch. Really simple changes.

Seth, please review.
Keywords: review
(Reporter)

Comment 4

18 years ago
Created attachment 20131 [details] [diff] [review]
Fix, version 1
(Reporter)

Comment 5

18 years ago
Oh, no, wait with the review please. We may want to skip the panel with the
hostnames only, but show the panel with the username, for ISP which offer
several accounts per customer. Will attach better patch later (might be a few days).
Keywords: review
(Reporter)

Updated

17 years ago
Target Milestone: mozilla0.9 → Future
Product: Browser → Seamonkey
Assignee: ben.bucksch → mail
Status: ASSIGNED → NEW
Priority: P3 → --
QA Contact: esther
Target Milestone: Future → ---

Comment 6

10 years ago
This bug should be WFM by now, the functionality I assume you meant is already present (or can be achieved by listing the pages). 

E.g. rss.rdf lists <NC:wizardSkipPanels>identitypage,serverpage,loginpage</NC:wizardSkipPanels>
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.