618642 - return 503+retry when memcache not available for storing tabs

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[:Atoll]

when memcache is not available for storing tabs, ensure that we return 503+retry.  we encountered this in production today and it appears that no 503s were returned to clients.

Comment 1

[Toby Elliott [:telliott]]

need to throw an error when tab set returns false - means we're down a memcache node

Comment 2

[Toby Elliott [:telliott]]

Attachment: Fails out if it can't write tab record to memcache

Since we would expect memcache to be flushed when we bring it back, trying to bail out on non-tab queries in a bad idea - we've already stored the data. 

If we do have a situation where memcache can come back with data intact, we should probably flush as a matter of policy, since the memcache wouldn't match the db

Comment 3

[Toby Elliott [:telliott]]

Attachment: Patch to bail out if no memcache on tabs

Comment 4

[:Atoll]

Mike: Do we plan to apply this patch to production PHP before we switch to Python?

Comment 5

[Tarek Ziadé (:tarek)]

I guess it's what you wanted here, but just to be sure:

On batch POSTs this error is swallowed -- and a 200 returned.

e.g. the 503 is logged but the client will get a list of failures/successes.

In Python I intend to log it in a log.error() call.

Comment 6

[Tarek Ziadé (:tarek)]

Pushing a patch for review on bug 627652

Comment 7

[Toby Elliott [:telliott]]

fixed in http://hg.mozilla.org/services/sync-server/rev/35d3160cdfbb