The default bug view has changed. See this FAQ.

Titlebar gradient breaks off abruptly at the toolbar in windows without tab bar when tabs are set on top

RESOLVED FIXED in Firefox 12

Status

()

Firefox
Theme
--
trivial
RESOLVED FIXED
6 years ago
3 years ago

People

(Reporter: bram, Assigned: dao)

Tracking

({polish})

Trunk
Firefox 12
All
Mac OS X
polish
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 2 obsolete attachments)

(Reporter)

Description

6 years ago
User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_5; en-US) AppleWebKit/534.13 (KHTML, like Gecko) Chrome/9.0.597.16 Safari/534.13
Build Identifier: Trunk

The gradient in the titlebar breaks off abruptly at the point at which it touches the toolbar when: 1) tabs is set on top, and 2) there is no tab open.

Educated guess/possible problem: the chrome stretches the gradient value down to fit an unexpanded space, creating a color that does not blend with its bottom neighbor

The same problem is also seen in the inactive window, though less pronounced.

Reproducible: Always

Steps to Reproduce:
1. Set Minefield to use Tabs on Top
2. Close all open tabs, leaving one open
Actual Results:  
Titlebar gradient eliminate abruptly at the toolbar.

Expected Results:  
Gradient should flow smoothly
(Reporter)

Comment 1

6 years ago
Created attachment 497220 [details]
Broken titlebar gradient when tabs is set on top
(Reporter)

Updated

6 years ago
Version: unspecified → Trunk
Dão, is it possible for the #nav-bar to tell whether the tabs toolbar is visible or not? If not, should we add an attribute to the toolbox?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: polish
Duplicate of this bug: 620105
Summary: Titlebar gradient breaks off abruptly at the toolbar when tabs is set on top → Titlebar gradient breaks off abruptly at the toolbar in windows without tab bar when tabs are set on top
Duplicate of this bug: 629382

Comment 5

6 years ago
Created attachment 508517 [details]
Gradient broken on a toolbarless window

I only see this effect in toolbar-less pop-up windows.
4.0b11pre(2011-01-31)
Mac OS 10.6.6

Comment 6

6 years ago
(In reply to comment #5)
Forgot to add, that this is also happening only with the 'Tabs on top' option enabled.
Duplicate of this bug: 639435
Duplicate of this bug: 641573

Comment 9

6 years ago
Just to confirm, this is still a problem in Firefox 4 RC2.

It happens whenever the tab bar is not visible.

This can happen in many situations such as popup windows, and also simply having no tabs open and the 'always show tab bar' setting unchecked.
(Reporter)

Comment 10

6 years ago
Firefox 4 works around this bug by having this "always show tab bar" setting turned on by default. Minefield doesn’t have this option, though.

Maybe we could implement this feature on Minefield so it’s easier to perform testing on this and other gradient-related bugs?
Blocks: 643867
Duplicate of this bug: 645989
(Reporter)

Comment 12

6 years ago
(In reply to comment #2)
> Dão, is it possible for the #nav-bar to tell whether the tabs toolbar is
> visible or not? If not, should we add an attribute to the toolbox?

I wonder if this bug is related to Bug 537273 - Make -moz-appearance: toolbar also draw a gradient if the toolbar is at the top of a drawintitlebar="true" window

https://bugzilla.mozilla.org/show_bug.cgi?id=537273
I was gonnna comment that this is fixed with the new look on latest Nightly.

But actually, I'm not seeing this under Aurora on 10.7 either. So it seems to be 10.5/10.6 only now.

Comment 14

6 years ago
I'm still seeing it under both today's nightly and Aurora 7.0a2 on 10.7.
Actually yeah, disregard Comment 13, bad testing on my part.
(Reporter)

Comment 16

6 years ago
I wonder if this bug depends on #<a href="https://bugzilla.mozilla.org/show_bug.cgi?id=668195">668195</a>?
(Reporter)

Comment 17

6 years ago
I meant to say Bug 668195. Sorry.
Created attachment 552342 [details] [diff] [review]
v1
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Attachment #552342 - Flags: review?(dao)
Duplicate of this bug: 685033
(Assignee)

Updated

6 years ago
Duplicate of this bug: 700049
(Assignee)

Comment 21

6 years ago
Comment on attachment 552342 [details] [diff] [review]
v1

I don't like the addition of the visibletabsontop attribute. Can we just not set the tabsontop attribute in that case? We'll need to remove persist="tabsontop" in browser.xul for that and do the persisting in the script.
Attachment #552342 - Flags: review?(dao) → review-
(Assignee)

Updated

6 years ago
Blocks: 621408
(Assignee)

Updated

6 years ago
Blocks: 576439
I've tried that idea and it didn't really work out. What should happen if somebody toggles the tabsontop checkbox while tabs are hidden? What values should the enabled getter return during that time? If the getter doesn't read the current state from tabsontop attribute, how should it know about the persisted value?
(Assignee)

Comment 23

5 years ago
(In reply to Markus Stange from comment #22)
> I've tried that idea and it didn't really work out. What should happen if
> somebody toggles the tabsontop checkbox while tabs are hidden?

The checkbox should probably be disabled or hidden; it might make sense to let the toggle function do nothing in that case, too.

> What values should the enabled getter return during that time?

Based on the two external places that read TabsOnTop.enabled, I'd say it should reflect the actual attribute state (not what's persisted).
(Assignee)

Comment 24

5 years ago
Created attachment 580788 [details] [diff] [review]
patch v2
Assignee: mstange → dao
Attachment #552342 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Severity: major → trivial
(Assignee)

Updated

5 years ago
Attachment #580788 - Flags: review?(gavin.sharp)
Comment on attachment 580788 [details] [diff] [review]
patch v2

Review of attachment 580788 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/nsBrowserGlue.js
@@ +1223,5 @@
>      }
>  
> +    if (currentUIVersion < 6) {
> +      // convert tabsontop attribute to pref
> +      let tooloxResource = this._rdf.GetResource(BROWSER_DOCURL + "navigator-toolbox");

nit: This should probably be toolboxResource
(Assignee)

Updated

5 years ago
Blocks: 643130
(Assignee)

Comment 26

5 years ago
Created attachment 580966 [details] [diff] [review]
patch v2

typofix
Attachment #580788 - Attachment is obsolete: true
Attachment #580966 - Flags: review?(gavin.sharp)
Attachment #580788 - Flags: review?(gavin.sharp)
(Assignee)

Updated

5 years ago
Attachment #580966 - Flags: review?(dolske)
Comment on attachment 580966 [details] [diff] [review]
patch v2

Review of attachment 580966 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't review this in depth, but looks fine. Flag again if you want a nitpicky review. :)
Attachment #580966 - Flags: review?(gavin.sharp)
Attachment #580966 - Flags: review?(dolske)
Attachment #580966 - Flags: review+
(Assignee)

Comment 28

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/5fbe5ee99a27
Target Milestone: --- → Firefox 12
(Assignee)

Comment 29

5 years ago
(In reply to Dão Gottwald [:dao] from comment #28)
> http://hg.mozilla.org/integration/mozilla-inbound/rev/5fbe5ee99a27

backed out because browser_bug321000.js was failing
The fix to the ally test has now been merged to m-c (https://hg.mozilla.org/mozilla-central/rev/e1b77400dc94), leaving open for the relanding of the main patch.
(Assignee)

Comment 31

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/440b585a2896
https://hg.mozilla.org/mozilla-central/rev/440b585a2896
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 33

5 years ago
There is a issue now. Filed bug 716334. Thanks.
(Assignee)

Updated

5 years ago
Depends on: 716334
(Assignee)

Updated

5 years ago
Depends on: 716692
Duplicate of this bug: 722826

Comment 35

5 years ago
Hi, there is still a bug. I filed bug 737158. Thanks.

Updated

5 years ago
Depends on: 749037

Updated

4 years ago
Depends on: 844651
You need to log in before you can comment on or make changes to this bug.