Last Comment Bug 6188 - Netlib returns NS_FALSE on errors
: Netlib returns NS_FALSE on errors
Status: VERIFIED INVALID
:
Product: Core
Classification: Components
Component: Networking (show other bugs)
: Trunk
: All Mac System 8.5
: P3 normal (vote)
: ---
Assigned To: Warren Harris
: Paul MacQuiddy
:
Mentors:
: 5675 (view as bug list)
Depends on:
Blocks: 7232
  Show dependency treegraph
 
Reported: 1999-05-10 12:54 PDT by Simon Fraser
Modified: 1999-12-13 16:32 PST (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments

Description Simon Fraser 1999-05-10 12:54:57 PDT
In various places (I counted 14), netlib is returning NS_FALSE on error. NS_FALSE
is #defined to 1 (really, NS_COMFALSE should be used if you want to return
this value at all).

The problem with returning NS_FALSE is that NS_SUCCEEDED(NS_FALSE) evaluates
to true, so callers who rely on SUCCEEDED() incorrectly assume that the call
succeeded.

Netlib should be returning real errors, preferably errors which useful
meanings.
Comment 1 Warren Harris 1999-06-04 10:56:59 PDT
Verify that this doesn't happen in necko.

*** This bug has been marked as a duplicate of 5571 ***
Comment 2 mcmullen 1999-06-04 11:22:59 PDT
This has nothing to do with #5571. Sorry, wrong number.

Reopening.
Comment 3 Simon Fraser 1999-06-04 11:38:59 PDT
Remove duplicate resolution
Comment 4 Warren Harris 1999-06-04 11:43:59 PDT
Why is this not a duplicate?
Comment 5 Simon Fraser 1999-06-04 11:45:59 PDT
Why would this be a duplicate of a bug concering the file locator?
Comment 6 Warren Harris 1999-06-04 17:41:59 PDT
*** Bug 5675 has been marked as a duplicate of this bug. ***
Comment 7 Warren Harris 1999-06-04 17:42:59 PDT
Sorry, that should have been #5657. I'm going to mark that one a dup of this.
Comment 8 leger 1999-07-20 12:13:59 PDT
Changing all Networking Library/Browser bugs to Networking-Core component for
Browser.

Occasionally, Bugzilla will burp and cause Verified bugs to reopen when I do
this in a bulk change.  If this happens, I will fix. ;-)
Comment 9 Warren Harris 1999-08-03 19:34:59 PDT
Not an issue with necko.
Comment 10 Paul MacQuiddy 1999-08-03 19:45:59 PDT
I will trust you on this
Comment 11 leger 1999-12-13 16:32:59 PST
Bulk move of all Networking-Core (to be deleted component) bugs to new
Networking component.

Note You need to log in before you can comment on or make changes to this bug.