The default bug view has changed. See this FAQ.

Netlib returns NS_FALSE on errors

VERIFIED INVALID

Status

()

Core
Networking
P3
normal
VERIFIED INVALID
18 years ago
18 years ago

People

(Reporter: Simon Fraser, Assigned: Warren Harris)

Tracking

Trunk
All
Mac System 8.5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

18 years ago
In various places (I counted 14), netlib is returning NS_FALSE on error. NS_FALSE
is #defined to 1 (really, NS_COMFALSE should be used if you want to return
this value at all).

The problem with returning NS_FALSE is that NS_SUCCEEDED(NS_FALSE) evaluates
to true, so callers who rely on SUCCEEDED() incorrectly assume that the call
succeeded.

Netlib should be returning real errors, preferably errors which useful
meanings.
(Assignee)

Updated

18 years ago
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → DUPLICATE
(Assignee)

Comment 1

18 years ago
Verify that this doesn't happen in necko.

*** This bug has been marked as a duplicate of 5571 ***

Updated

18 years ago
Status: RESOLVED → REOPENED

Comment 2

18 years ago
This has nothing to do with #5571. Sorry, wrong number.

Reopening.
(Reporter)

Updated

18 years ago
Resolution: DUPLICATE → ---
(Reporter)

Comment 3

18 years ago
Remove duplicate resolution
(Assignee)

Comment 4

18 years ago
Why is this not a duplicate?
(Reporter)

Comment 5

18 years ago
Why would this be a duplicate of a bug concering the file locator?
(Assignee)

Comment 6

18 years ago
*** Bug 5675 has been marked as a duplicate of this bug. ***
(Assignee)

Updated

18 years ago
Status: REOPENED → ASSIGNED
Depends on: 7232
(Assignee)

Comment 7

18 years ago
Sorry, that should have been #5657. I'm going to mark that one a dup of this.

Updated

18 years ago
No longer depends on: 7232

Updated

18 years ago
Blocks: 7232

Comment 8

18 years ago
Changing all Networking Library/Browser bugs to Networking-Core component for
Browser.

Occasionally, Bugzilla will burp and cause Verified bugs to reopen when I do
this in a bulk change.  If this happens, I will fix. ;-)
(Assignee)

Updated

18 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago18 years ago
Resolution: --- → INVALID
(Assignee)

Comment 9

18 years ago
Not an issue with necko.

Updated

18 years ago
Status: RESOLVED → VERIFIED

Comment 10

18 years ago
I will trust you on this

Comment 11

18 years ago
Bulk move of all Networking-Core (to be deleted component) bugs to new
Networking component.
You need to log in before you can comment on or make changes to this bug.