Closed
Bug 618842
Opened 14 years ago
Closed 14 years ago
Enclose checksetup.pl between <kbd> and </kbd> tags in templates
Categories
(Bugzilla :: Documentation, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.0
People
(Reporter: himorin, Assigned: himorin)
Details
Attachments
(1 file, 1 obsolete file)
|
8.09 KB,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
Should all "checksetup.pl" be quoted with kbd tag in release note?
|
||
Comment 1•14 years ago
|
||
Most places uses <kbd>, a few <code>, and some none. I suppose that for consistency, we should use <kbd> everywhere.
|
||
Comment 2•14 years ago
|
||
Comment on attachment 497269 [details] [diff] [review]
patch v.1
Sure, seems reasonable.
Attachment #497269 -
Flags: review+
|
|
||
Updated•14 years ago
|
Flags: approval+
Target Milestone: --- → Bugzilla 4.2
|
|
||
Comment 3•14 years ago
|
||
No, wait. Not all places have been fixed.
|
|
||
Updated•14 years ago
|
Flags: approval4.0+
Target Milestone: Bugzilla 4.2 → Bugzilla 4.0
|
|
||
Comment 5•14 years ago
|
||
Comment on attachment 497269 [details] [diff] [review]
patch v.1
Yeah, let's fix all the places.
Attachment #497269 -
Flags: review+ → review-
|
Assignee | |
Comment 6•14 years ago
|
||
patch v.2
I think it's all for template files in template/en. (excpet for strings.txt.pl)
Attachment #497269 -
Attachment is obsolete: true
|
|
||
Comment 7•14 years ago
|
||
Comment on attachment 497809 [details] [diff] [review]
patch v.2
Looks good to me. :-)
Attachment #497809 -
Flags: review+
|
|
||
Updated•14 years ago
|
Flags: approval4.0+
Flags: approval+
|
|
||
Comment 8•14 years ago
|
||
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/admin/params/dependencygraph.html.tmpl
modified template/en/default/admin/params/general.html.tmpl
modified template/en/default/admin/params/mta.html.tmpl
modified template/en/default/global/messages.html.tmpl
modified template/en/default/pages/release-notes.html.tmpl
Committed revision 7637.
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/
modified template/en/default/admin/params/dependencygraph.html.tmpl
modified template/en/default/admin/params/general.html.tmpl
modified template/en/default/admin/params/mta.html.tmpl
modified template/en/default/global/messages.html.tmpl
modified template/en/default/pages/release-notes.html.tmpl
Committed revision 7504.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Summary: Should "checksetup.pl" be quoted with kbd tag in release note? → Enclose checksetup.pl between <kbd> and </kbd> tags in templates
You need to log in
before you can comment on or make changes to this bug.
Description
•