618900 - Ctrl+S should save editing progress

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect)

Description

[Daniel Buchner [:dbuc]]

We will need a way to show the unsaved state in the UI. I will post an attachment with a mock.

Comment 1

[Andy McKay]

adds in ctrl+s https://github.com/andymckay/FlightDeck/commit/67d6ac6d6be7abd2758c21d134e5a6f0e26b6a63

any progress on the mockup for the unsaved state?

Comment 2

[Daniel Buchner [:dbuc]]

Attachment: Save button with a saved state indicator

Comment 3

[Daniel Buchner [:dbuc]]

Here is what I'm thinking (view attached for context), we have either an image or a span, your choice, that we flip between red and green to indicate the saved/unsaved state.

The title of the button should indicate the present state. Something like "You have unsaved changes" and "All documents are in sync".

Comment 4

[Wil Clouser [:clouserw]]

I'm not sure which apps, but what I've seen for these types of situations is an enabled/disabled button (with mouseover explanation tooltips).

Comment 5

[Piotr Zalewa [:zalun]]

That's how it was working before switching off as apparently it wasn't working on Windows - I will try to switch it on again, but I guess the best would be to wait for new editor.

Comment 6

[Daniel Buchner [:dbuc]]

Wil, see above ;)

Comment 7

[Andy McKay]

Which part wasn't working zalun, notification/polling of the editor to find out what has changed? If so will wait for Skywriter to land then.

Comment 8

[Daniel Buchner [:dbuc]]

Even if this is just one command, we should implement this via a new Keyboard controller so that we can really easily add others later. 

See here for more info: http://mootools.net/docs/more/Interface/Keyboard

Comment 9

[Andy McKay]

https://github.com/mozilla/FlightDeck/commit/7847f88c54a81ecc030755dfd4a8562144e2bd5b